From patchwork Wed Dec 9 06:22:38 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nir Tzachar X-Patchwork-Id: 65889 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nB96Mg6P004192 for ; Wed, 9 Dec 2009 06:22:42 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754221AbZLIGWe (ORCPT ); Wed, 9 Dec 2009 01:22:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754973AbZLIGWe (ORCPT ); Wed, 9 Dec 2009 01:22:34 -0500 Received: from mail-fx0-f213.google.com ([209.85.220.213]:46421 "EHLO mail-fx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754221AbZLIGWd convert rfc822-to-8bit (ORCPT ); Wed, 9 Dec 2009 01:22:33 -0500 Received: by fxm5 with SMTP id 5so7107807fxm.28 for ; Tue, 08 Dec 2009 22:22:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=jvLvyoEbtaoUhVCUfY1spTVOlGwAj9SFKXpE7gOhcWo=; b=o0hO67F4gWoRojePVMJxktQtZe0T56gtNvu16yUpcIiPLCd6D2wdnXIfIDS9gCbpPa EuQrBLfhD3t5BZw1HfDqr87phqi44eE1AxihQuGFUlqFogv2nZSxSGKXx5Dj3ePPuIOy Me23RpDXWvslhRXfb0et5hrONlc7VH2p52sqM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=IPYknf1RbDzWU3qy3ap3s+jDWU5IxDGm9LGU+sd51VS1f9ymYjxtdABfGOTtNE2T0F BXFYGCJ2v9Ag6Jv8/bXol+CUTR8Du1YAx/kPFT3Q4NRHJ3x/szm6d1dsDhVzD9C4ZQLE 6ECUeiUgJ2+yhL2nNvCQXWJPNZ8djIk2Y42SA= MIME-Version: 1.0 Received: by 10.223.97.132 with SMTP id l4mr90353fan.100.1260339758685; Tue, 08 Dec 2009 22:22:38 -0800 (PST) In-Reply-To: <4B1EB5E9.3010506@suse.cz> References: <1260276751-19501-1-git-send-email-mmarek@suse.cz> <200912081611.12625.a.miskiewicz@gmail.com> <4B1EAF69.5090609@suse.cz> <200912082107.19192.a.miskiewicz@gmail.com> <4B1EB5E9.3010506@suse.cz> Date: Wed, 9 Dec 2009 08:22:38 +0200 Message-ID: <9b2db90b0912082222x5287d452pf9e55d6ff44e511c@mail.gmail.com> Subject: Re: [PATCH] MAINTAINERS: new kbuild maintainer From: Nir Tzachar To: Michal Marek Cc: Arkadiusz Miskiewicz , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org diff --git a/scripts/kconfig/lxdialog/check-lxdialog.sh b/scripts/kconfig/lxdialog/check-lxdialog.sh index fcef0f5..5596d0c 100644 --- a/scripts/kconfig/lxdialog/check-lxdialog.sh +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh @@ -5,7 +5,7 @@ ldflags() { for ext in so a dylib ; do - for lib in ncursesw ncurses curses ; do + for lib in ncurses curses ; do $cc -print-file-name=lib${lib}.${ext} | grep -q / if [ $? -eq 0 ]; then echo "-l${lib}" Moreover, currently nconfig does not use this check. It should be made common to both mconf and nconf, and we need to make sure adding the appropriate libraries only to the targets which need them (currently, -lncurses is added to all targets in scripts/kbuild ...) Below is a very hackish patch which does this. However, having a proper Makefile for lxdialog would be much better. diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index 6d69c7c..e0c7714 100644 --- a/scripts/kconfig/Makefile +++ b/scripts/kconfig/Makefile @@ -23,6 +23,9 @@ menuconfig: $(obj)/mconf config: $(obj)/conf $< $(Kconfig) +nconfig: $(obj)/nconf + $< $(Kconfig) + oldconfig: $(obj)/conf $< -o $(Kconfig) @@ -109,6 +112,7 @@ endif # Help text used by make help help: @echo ' config - Update current config utilising a line-oriented program' + @echo ' nconfig - Update current config utilising a ncurses menu based program' @echo ' menuconfig - Update current config utilising a menu based program' @echo ' xconfig - Update current config utilising a QT based front-end'