From patchwork Tue Sep 21 16:57:47 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Arnaud Lacombe <lacombar@gmail.com>
X-Patchwork-Id: 197602
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o8LGvpkh025555
	for <patchwork-kbuild@patchwork.kernel.org>;
	Tue, 21 Sep 2010 16:57:51 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757569Ab0IUQ5t (ORCPT
	<rfc822;patchwork-kbuild@patchwork.kernel.org>);
	Tue, 21 Sep 2010 12:57:49 -0400
Received: from mail-ww0-f44.google.com ([74.125.82.44]:40586 "EHLO
	mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754059Ab0IUQ5s (ORCPT
	<rfc822;linux-kbuild@vger.kernel.org>);
	Tue, 21 Sep 2010 12:57:48 -0400
Received: by wwi17 with SMTP id 17so191424wwi.1
	for <linux-kbuild@vger.kernel.org>;
	Tue, 21 Sep 2010 09:57:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:in-reply-to
	:references:date:message-id:subject:from:to:cc:content-type;
	bh=HCFahwWVimEyLOYsly3F0Aj4okDIME38TJzdja1dSqE=;
	b=ArxCdXemI6lXkx9YtUukTfZR/pqGSUuCyVIBc+lOJ2y8atATsHiWTyRVahqt34goO0
	vaQO2xsH4YuA+l84v7T2TeDyBsyEEV9Ul5yKIqhhGEtigXOqx9F/9FKY/8En6KAJ0ZyD
	+lRyV+3/A8QB0n+JG/3YPI+UgWEu1JuJaiYl0=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=VbfAU0hwanwkeOHrIgh8S7Zlz7RfRAtNlGY2nJQW4bdvr82vEL+sqfNy1VLqGo9xO8
	PMHdZbGRdlH3QeUGODasgoL8NCrnU6/GveCuDZqkN/vAu1196E4LyGe66Zc4eAlDxLMi
	D6tPuI+Ef1dYuU6M0CYo3JyvLTbCHWfbie9j0=
MIME-Version: 1.0
Received: by 10.216.179.20 with SMTP id g20mr9453544wem.45.1285088267285;
	Tue, 21 Sep 2010 09:57:47 -0700 (PDT)
Received: by 10.216.229.99 with HTTP; Tue, 21 Sep 2010 09:57:47 -0700 (PDT)
In-Reply-To: <tnxpqw7hw8b.fsf@e102109-lin.cambridge.arm.com>
References: <AANLkTim1EmMOFERs7rwG=zg_AZrXtojE7dKV7Rhf17Ww@mail.gmail.com>
	<AANLkTinMZj-_neS4jNM+b6-Dk7qzVMsR6DwyX2SHk3kt@mail.gmail.com>
	<1285072379.15732.70.camel@e102109-lin.cambridge.arm.com>
	<AANLkTi=fudCXbVEwcAjz+a3ZvM-r8i5A1yH-=n63o2o8@mail.gmail.com>
	<tnxtyljhxr9.fsf@e102109-lin.cambridge.arm.com>
	<AANLkTi=2JjY_0FwkMgDqpR3uOVci5Ljc1WswgmShBs+U@mail.gmail.com>
	<tnxpqw7hw8b.fsf@e102109-lin.cambridge.arm.com>
Date: Tue, 21 Sep 2010 12:57:47 -0400
Message-ID: <AANLkTi=LceTkH+PsWg4ORMPO33c=sdY9nA3NA102DK9L@mail.gmail.com>
Subject: Re: Stale expression reference causing use-after-free
From: Arnaud Lacombe <lacombar@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Michal Marek <mmarek@suse.cz>,
	"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>
Sender: linux-kbuild-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kbuild.vger.kernel.org>
X-Mailing-List: linux-kbuild@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]);
	Tue, 21 Sep 2010 16:57:51 +0000 (UTC)


diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 23acbdb..9eee093 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -107,7 +107,6 @@ static struct expr *menu_check_dep(struct expr *e)
 void menu_add_dep(struct expr *dep)
 {
        current_entry->dep = expr_alloc_and(current_entry->dep,
menu_check_dep(dep));
-       current_entry->dir_dep = current_entry->dep;
 }