From patchwork Tue Nov 29 17:10:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Torvalds X-Patchwork-Id: 9452759 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2D6D26071C for ; Tue, 29 Nov 2016 17:11:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C4082835D for ; Tue, 29 Nov 2016 17:11:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10CF828399; Tue, 29 Nov 2016 17:11:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID,T_TVD_MIME_EPI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CEF72835D for ; Tue, 29 Nov 2016 17:11:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756127AbcK2RLL (ORCPT ); Tue, 29 Nov 2016 12:11:11 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:34140 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754531AbcK2RLF (ORCPT ); Tue, 29 Nov 2016 12:11:05 -0500 Received: by mail-io0-f194.google.com with SMTP id r94so30606330ioe.1; Tue, 29 Nov 2016 09:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4Tzd0uIMCDh7QPzUvVHkF7nt8mrTgF7gNHGAplbMt8s=; b=eBUhLQO9aT9UVNTZvb4BH8Aoqq61DEgKhqfL3HPfqt7XXZsmK2lzMXDo6X0IoJXH4I a9Q4xKu/KA0PT8rpIMdKDrM2YtJdmd0V3D/EEtAq3xE4BRPXL/jf1cCT5y0pkVHw18ZN 94MUNrsAfra3Egud2oBQM0V8WM2fy958Y0WdFBzk7B5xNVqQawBrQqzPo0IWQQyGzmEg uJoAJIKBiVahjYkEw1mU8Qg44SEnHOfZeTTZtiAQE7jvx33XVjL92mP3EnfFi9oRGp3h jdcETu5IaCH68+Hrxzq7LY+Nj7067KRPdplGFkXfr5T+GkvtenLe73HfPoOb7dUDPnSJ KAyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4Tzd0uIMCDh7QPzUvVHkF7nt8mrTgF7gNHGAplbMt8s=; b=QUTIKS5mSABMhASHzEHUP9E/Bq7t3OWN1vJeXOPpIxfB5hxhJvytJazE/TNkisPad4 49cx7ePHKveVP+iKWA+2N0/nyaPRWjqvSJx3TvvZnieLb5G8iWDfEfNc0oHPIdH4JUS8 KkdhvU3SIOZ/L+LuU50EmMX+A7GSAR2e9g3bncxtJ6aHf+GLGIbnM0JkxvjRL0nVmhuA rprBaimY8AEErqsEVjG/MlLBRwe2TgMT69wGVFyEYkpIIcwKhjVq+gndcMqfRaLwq49k jziw4jjhtoibq4RFYp40j/P98wcVHTjRUXGBIuIXojFmAkSE2zlUHYXrva2u4hDAJfVR OZXg== X-Gm-Message-State: AKaTC01No6Rbel1Zx36h67WcKLRqqB+nIsI1Lvt5QQMModqXUas06XSOaAq9IsxfS9ilE16hstHoaS5qKz5I+Q== X-Received: by 10.107.5.210 with SMTP id 201mr22906519iof.189.1480439459118; Tue, 29 Nov 2016 09:10:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.146.65 with HTTP; Tue, 29 Nov 2016 09:10:58 -0800 (PST) In-Reply-To: <20161129170522.GA3441@angband.pl> References: <20161129131922.GA31466@angband.pl> <20161129135118.24696-1-kilobyte@angband.pl> <20161129170522.GA3441@angband.pl> From: Linus Torvalds Date: Tue, 29 Nov 2016 09:10:58 -0800 X-Google-Sender-Auth: AXX_L_vf0HFjBY28xkx6XakTQfo Message-ID: Subject: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm To: Adam Borowski Cc: Greg Kroah-Hartman , Linux Kbuild mailing list , Michal Marek , Ben Hutchings , Debian kernel maintainers , "linux-arch@vger.kernel.org" , Arnd Bergmann , Ingo Molnar , Nicholas Piggin , Linux Kernel Mailing List Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Nov 29, 2016 at 9:05 AM, Adam Borowski wrote: > > Thus, if it's indeed binutils, you'll see the breakage as soon as Fedora > recovers from the freeze. So quite frankly, I don't want to make our kernel sources worse due to broken shit tools getting something wrong that we shouldn't even care about. How about this stupid patch? It weakens modversions, but that may be ok for Debian, and a better alternative than just saying "we don't support it at all". Linus kernel/module.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/module.c b/kernel/module.c index f57dd63186e6..0e54d5bf0097 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1301,8 +1301,9 @@ static int check_version(Elf_Shdr *sechdrs, goto bad_version; } - pr_warn("%s: no symbol version for %s\n", mod->name, symname); - return 0; + /* Broken toolchain. Warn once, then let it go.. */ + pr_warn_once("%s: no symbol version for %s\n", mod->name, symname); + return 1; bad_version: pr_warn("%s: disagrees about version of symbol %s\n",