[RFC,1/1] kconfig: drop localization support

Commit Message

Masahiro Yamada May 24, 2018, 2:21 p.m. UTC

Hi Sam,



2018-05-23 13:46 GMT+09:00 Sam Ravnborg <[e-mail]>:
> Hi Masahiro.
>
>> > Ulf Magnusson originally mentioned this removal some time ago.
>> >
>> > So, here is his tag.
>> > Suggested-by: Ulf Magnusson <[e-mail]>
> Added.
>
>> PHONY += xconfig gconfig menuconfig config syncconfig update-po-config \
>>      localmodconfig localyesconfig
>>
>>
>> The 'update-po-config' is left-over in the PHONY assignment.
> Good catch.
>
>> This is simple, so I can fix it up locally.
> Fine
>
> If there is any other feedback I will respin the patch.
>
>         Sam
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to [e-mail]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


Applied to linux-kbuild/kconfig.  Thanks!


When I applied this, I added the following fix-up.







.mo is no longer generated.

It was added by
commit c26dd719a5b9d94d12211f2d101bd7dffb7f9f1f



Please double-check if it is OK.

Comments

Sam Ravnborg May 24, 2018, 3:41 p.m. UTC | #1

Hi Masahiro

> 
> When I applied this, I added the following fix-up.
> 
> 
> 
> diff --git a/scripts/kconfig/.gitignore b/scripts/kconfig/.gitignore
> index 54266f3..0aabc1d 100644
> --- a/scripts/kconfig/.gitignore
> +++ b/scripts/kconfig/.gitignore
> @@ -2,7 +2,6 @@
>  # Generated files
>  #
>  *.moc
> -*.mo
> 
>  #
>  # configuration programs
> 
> 
> 
> 
> .mo is no longer generated.
> 
> It was added by
> commit c26dd719a5b9d94d12211f2d101bd7dffb7f9f1f
> 
> 
> 
> Please double-check if it is OK.

I left it as I was not sure where the .mo extension came from.
And trying out the different frontends did not generate
any .mo files (I tried with a kernel before my patches).

So I assume the .mo extension was added because it is
often seen in combination with .pot files,
and not because the kernel actually generated such file.

See https://make.wordpress.org/polyglots/handbook/glossary/#mo-files
for a short description of the .mo files.

In other words - the fixup is correct. Thanks!

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/scripts/kconfig/.gitignore b/scripts/kconfig/.gitignore
index 54266f3..0aabc1d 100644
--- a/scripts/kconfig/.gitignore
+++ b/scripts/kconfig/.gitignore
@@ -2,7 +2,6 @@ 
 # Generated files
 #
 *.moc
-*.mo

 #
 # configuration programs