| Message ID | ZhmKzqxHXaSZmXee@mozart.vkv.me (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] kbuild: buildtar: Add explicit 32-bit arm support | expand |
On Fri, Apr 12, 2024 at 12:26:06PM -0700, Calvin Owens wrote: > Implement buildtar for 32-bit arm, so the zImage (or xipimage) appears > at boot/vmlinuz-$foo, rather than at boot/vmlinux-kbuild-$foo, matching > the structure of the tar-pkg on arm64 and other architectures. > > Link: https://lore.kernel.org/all/e7c14a0d329e28bdcda21376b54a43c85a4aaf3f.1712682861.git.calvin@wbinvd.org/ > Signed-off-by: Calvin Owens <calvin@wbinvd.org> Looks good to me, especially with the added justification of matching other architectures. Reviewed-by: Nathan Chancellor <nathan@kernel.org> > --- > scripts/package/buildtar | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/scripts/package/buildtar b/scripts/package/buildtar > index 72c91a1b832f..86035c990aec 100755 > --- a/scripts/package/buildtar > +++ b/scripts/package/buildtar > @@ -101,6 +101,9 @@ case "${ARCH}" in > fi > done > ;; > + arm) > + [ -f "${KBUILD_IMAGE}" ] && cp -v -- "${KBUILD_IMAGE}" "${tmpdir}/boot/vmlinuz-${KERNELRELEASE}" > + ;; > *) > [ -f "${KBUILD_IMAGE}" ] && cp -v -- "${KBUILD_IMAGE}" "${tmpdir}/boot/vmlinux-kbuild-${KERNELRELEASE}" > echo "" >&2 > -- > 2.39.2 >
diff --git a/scripts/package/buildtar b/scripts/package/buildtar index 72c91a1b832f..86035c990aec 100755 --- a/scripts/package/buildtar +++ b/scripts/package/buildtar @@ -101,6 +101,9 @@ case "${ARCH}" in fi done ;; + arm) + [ -f "${KBUILD_IMAGE}" ] && cp -v -- "${KBUILD_IMAGE}" "${tmpdir}/boot/vmlinuz-${KERNELRELEASE}" + ;; *) [ -f "${KBUILD_IMAGE}" ] && cp -v -- "${KBUILD_IMAGE}" "${tmpdir}/boot/vmlinux-kbuild-${KERNELRELEASE}" echo "" >&2
Implement buildtar for 32-bit arm, so the zImage (or xipimage) appears at boot/vmlinuz-$foo, rather than at boot/vmlinux-kbuild-$foo, matching the structure of the tar-pkg on arm64 and other architectures. Link: https://lore.kernel.org/all/e7c14a0d329e28bdcda21376b54a43c85a4aaf3f.1712682861.git.calvin@wbinvd.org/ Signed-off-by: Calvin Owens <calvin@wbinvd.org> --- scripts/package/buildtar | 3 +++ 1 file changed, 3 insertions(+)