diff mbox series

[V2,1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE

Message ID be5cb12a68d9ac2c35ad9dd50d6b168f7cad6837.1609996381.git.viresh.kumar@linaro.org (mailing list archive)
State New
Headers show
Series [V2,1/2] scripts: dtc: Add fdtoverlay.c and fdtdump.c to DTC_SOURCE | expand

Commit Message

Viresh Kumar Jan. 7, 2021, 5:15 a.m. UTC
We will start building overlays for platforms soon in the kernel and
would need these tools going forward. Lets start fetching them.

Note that a copy of fdtdump.c was already copied back in the year 2012,
but was never updated or built for some reason.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
V2: Separate out this change from Makefile one.

This needs to be followed by invocation of the ./update-dtc-source.sh
script so the relevant files can be copied before the Makefile is
updated in the next patch.

 scripts/dtc/update-dtc-source.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Frank Rowand Jan. 11, 2021, 10:13 p.m. UTC | #1
Hi Viresh,

On 1/6/21 11:15 PM, Viresh Kumar wrote:
> We will start building overlays for platforms soon in the kernel and
> would need these tools going forward. Lets start fetching them.
> 
> Note that a copy of fdtdump.c was already copied back in the year 2012,
> but was never updated or built for some reason.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> V2: Separate out this change from Makefile one.
> 
> This needs to be followed by invocation of the ./update-dtc-source.sh
> script so the relevant files can be copied before the Makefile is
> updated in the next patch.

Just an FYI that Rob will do the ./update-dtc-source.sh step at the appropriate
time, creating a commit to be submitted in his pull request to Linus.

That way Rob will ensure that all of the updates from the parent project are
updated in a careful manner.

-Frank

> 
>  scripts/dtc/update-dtc-source.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/dtc/update-dtc-source.sh b/scripts/dtc/update-dtc-source.sh
> index bc704e2a6a4a..9bc4afb71415 100755
> --- a/scripts/dtc/update-dtc-source.sh
> +++ b/scripts/dtc/update-dtc-source.sh
> @@ -31,9 +31,9 @@ set -ev
>  DTC_UPSTREAM_PATH=`pwd`/../dtc
>  DTC_LINUX_PATH=`pwd`/scripts/dtc
>  
> -DTC_SOURCE="checks.c data.c dtc.c dtc.h flattree.c fstree.c livetree.c srcpos.c \
> -		srcpos.h treesource.c util.c util.h version_gen.h yamltree.c \
> -		dtc-lexer.l dtc-parser.y"
> +DTC_SOURCE="checks.c data.c dtc.c dtc.h fdtdump.c fdtoverlay.c flattree.c \
> +		fstree.c livetree.c srcpos.c srcpos.h treesource.c util.c \
> +		util.h version_gen.h yamltree.c dtc-lexer.l dtc-parser.y"
>  LIBFDT_SOURCE="fdt.c fdt.h fdt_addresses.c fdt_empty_tree.c \
>  		fdt_overlay.c fdt_ro.c fdt_rw.c fdt_strerror.c fdt_sw.c \
>  		fdt_wip.c libfdt.h libfdt_env.h libfdt_internal.h"
>
Viresh Kumar Jan. 12, 2021, 4:45 a.m. UTC | #2
On 11-01-21, 16:13, Frank Rowand wrote:
> Hi Viresh,
> 
> On 1/6/21 11:15 PM, Viresh Kumar wrote:
> > We will start building overlays for platforms soon in the kernel and
> > would need these tools going forward. Lets start fetching them.
> > 
> > Note that a copy of fdtdump.c was already copied back in the year 2012,
> > but was never updated or built for some reason.
> > 
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > V2: Separate out this change from Makefile one.
> > 
> > This needs to be followed by invocation of the ./update-dtc-source.sh
> > script so the relevant files can be copied before the Makefile is
> > updated in the next patch.
> 
> Just an FYI that Rob will do the ./update-dtc-source.sh step at the appropriate
> time, creating a commit to be submitted in his pull request to Linus.
> 
> That way Rob will ensure that all of the updates from the parent project are
> updated in a careful manner.

Right, this is what I expected. I still wrote this in the patch
description to make sure others, who may want to try this stuff,
understand how this works.
Frank Rowand Jan. 19, 2021, 4:21 p.m. UTC | #3
On 1/6/21 11:15 PM, Viresh Kumar wrote:
> We will start building overlays for platforms soon in the kernel and
> would need these tools going forward. Lets start fetching them.
> 
> Note that a copy of fdtdump.c was already copied back in the year 2012,
> but was never updated or built for some reason.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> V2: Separate out this change from Makefile one.
> 
> This needs to be followed by invocation of the ./update-dtc-source.sh
> script so the relevant files can be copied before the Makefile is
> updated in the next patch.
> 
>  scripts/dtc/update-dtc-source.sh | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/dtc/update-dtc-source.sh b/scripts/dtc/update-dtc-source.sh
> index bc704e2a6a4a..9bc4afb71415 100755
> --- a/scripts/dtc/update-dtc-source.sh
> +++ b/scripts/dtc/update-dtc-source.sh
> @@ -31,9 +31,9 @@ set -ev
>  DTC_UPSTREAM_PATH=`pwd`/../dtc
>  DTC_LINUX_PATH=`pwd`/scripts/dtc
>  
> -DTC_SOURCE="checks.c data.c dtc.c dtc.h flattree.c fstree.c livetree.c srcpos.c \
> -		srcpos.h treesource.c util.c util.h version_gen.h yamltree.c \
> -		dtc-lexer.l dtc-parser.y"
> +DTC_SOURCE="checks.c data.c dtc.c dtc.h fdtdump.c fdtoverlay.c flattree.c \
> +		fstree.c livetree.c srcpos.c srcpos.h treesource.c util.c \
> +		util.h version_gen.h yamltree.c dtc-lexer.l dtc-parser.y"
>  LIBFDT_SOURCE="fdt.c fdt.h fdt_addresses.c fdt_empty_tree.c \
>  		fdt_overlay.c fdt_ro.c fdt_rw.c fdt_strerror.c fdt_sw.c \
>  		fdt_wip.c libfdt.h libfdt_env.h libfdt_internal.h"
> 

DTC_SOURCE is for the dtc program.  Please add a FDTOVERLAY_SOURCE and
related use for the fdtoverlay program.

-Frank
Frank Rowand Jan. 19, 2021, 4:31 p.m. UTC | #4
On 1/19/21 10:21 AM, Frank Rowand wrote:
> On 1/6/21 11:15 PM, Viresh Kumar wrote:
>> We will start building overlays for platforms soon in the kernel and
>> would need these tools going forward. Lets start fetching them.
>>
>> Note that a copy of fdtdump.c was already copied back in the year 2012,
>> but was never updated or built for some reason.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> ---
>> V2: Separate out this change from Makefile one.
>>
>> This needs to be followed by invocation of the ./update-dtc-source.sh
>> script so the relevant files can be copied before the Makefile is
>> updated in the next patch.
>>
>>  scripts/dtc/update-dtc-source.sh | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/scripts/dtc/update-dtc-source.sh b/scripts/dtc/update-dtc-source.sh
>> index bc704e2a6a4a..9bc4afb71415 100755
>> --- a/scripts/dtc/update-dtc-source.sh
>> +++ b/scripts/dtc/update-dtc-source.sh
>> @@ -31,9 +31,9 @@ set -ev
>>  DTC_UPSTREAM_PATH=`pwd`/../dtc
>>  DTC_LINUX_PATH=`pwd`/scripts/dtc
>>  
>> -DTC_SOURCE="checks.c data.c dtc.c dtc.h flattree.c fstree.c livetree.c srcpos.c \
>> -		srcpos.h treesource.c util.c util.h version_gen.h yamltree.c \
>> -		dtc-lexer.l dtc-parser.y"
>> +DTC_SOURCE="checks.c data.c dtc.c dtc.h fdtdump.c fdtoverlay.c flattree.c \
>> +		fstree.c livetree.c srcpos.c srcpos.h treesource.c util.c \
>> +		util.h version_gen.h yamltree.c dtc-lexer.l dtc-parser.y"
>>  LIBFDT_SOURCE="fdt.c fdt.h fdt_addresses.c fdt_empty_tree.c \
>>  		fdt_overlay.c fdt_ro.c fdt_rw.c fdt_strerror.c fdt_sw.c \
>>  		fdt_wip.c libfdt.h libfdt_env.h libfdt_internal.h"
>>
> 
> DTC_SOURCE is for the dtc program.  Please add a FDTOVERLAY_SOURCE and
> related use for the fdtoverlay program.

I see that this patch series is up to v4, so I commented in the wrong place.
I will repeat this comment in the v4 series.

-Frank

> 
> -Frank
>
diff mbox series

Patch

diff --git a/scripts/dtc/update-dtc-source.sh b/scripts/dtc/update-dtc-source.sh
index bc704e2a6a4a..9bc4afb71415 100755
--- a/scripts/dtc/update-dtc-source.sh
+++ b/scripts/dtc/update-dtc-source.sh
@@ -31,9 +31,9 @@  set -ev
 DTC_UPSTREAM_PATH=`pwd`/../dtc
 DTC_LINUX_PATH=`pwd`/scripts/dtc
 
-DTC_SOURCE="checks.c data.c dtc.c dtc.h flattree.c fstree.c livetree.c srcpos.c \
-		srcpos.h treesource.c util.c util.h version_gen.h yamltree.c \
-		dtc-lexer.l dtc-parser.y"
+DTC_SOURCE="checks.c data.c dtc.c dtc.h fdtdump.c fdtoverlay.c flattree.c \
+		fstree.c livetree.c srcpos.c srcpos.h treesource.c util.c \
+		util.h version_gen.h yamltree.c dtc-lexer.l dtc-parser.y"
 LIBFDT_SOURCE="fdt.c fdt.h fdt_addresses.c fdt_empty_tree.c \
 		fdt_overlay.c fdt_ro.c fdt_rw.c fdt_strerror.c fdt_sw.c \
 		fdt_wip.c libfdt.h libfdt_env.h libfdt_internal.h"