From patchwork Mon Jun 24 18:11:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yann E. MORIN" X-Patchwork-Id: 2772921 Return-Path: X-Original-To: patchwork-linux-kbuild@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3523A9F758 for ; Mon, 24 Jun 2013 18:16:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4583220288 for ; Mon, 24 Jun 2013 18:16:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 428892027D for ; Mon, 24 Jun 2013 18:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751255Ab3FXSQj (ORCPT ); Mon, 24 Jun 2013 14:16:39 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:42880 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553Ab3FXSMN (ORCPT ); Mon, 24 Jun 2013 14:12:13 -0400 Received: by mail-wi0-f180.google.com with SMTP id c10so2752230wiw.13 for ; Mon, 24 Jun 2013 11:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:in-reply-to:references; bh=nQp/cuHxUNwYUUqRJ+OD1mqur64C/3jDezcipjMrufM=; b=kJVC7fcczUpin6nSzsaFAghSRSu69hWP/vOwhHuP8Uxu9r4lwhIMF5mkYJB8LUvRuh sWhjW3BpEXrkUg9OmQysxZmkHSrlAd6jobeU4TPoF6xLsCsfZjnKrkbyo3DzQ7Urnh0m hUq7jSkUMczV1KmAeuxs/Gqd4aylTUK15R3nvdMVPCMiBgPdjHfNLfm1J34Ae2jOgj4T OSNYb7IZHo4BNcWSlcQO1uZ6YKz3jD8j1/mEHOmri4UhJYX/qXHL9BF/hYZizlAoVKeq J/w0zW3DIK/M4CakDpUevWVJJfzx6Y/T6SxeI+XEkr3fjn7arnhrh1G99rRc4WSrDq5W Uv2g== X-Received: by 10.194.243.129 with SMTP id wy1mr17448450wjc.47.1372097532030; Mon, 24 Jun 2013 11:12:12 -0700 (PDT) Received: from gourin.bzh.lan (ks3095497.kimsufi.com. [94.23.60.27]) by mx.google.com with ESMTPSA id ev19sm1708664wid.2.2013.06.24.11.12.10 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 24 Jun 2013 11:12:11 -0700 (PDT) From: "Yann E. MORIN" To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michal Marek , Sedat Dilek , "Yann E. MORIN" Subject: [PATCH 03/15] kconfig/lxdialog: Use new mininimum resize definitions in conf_choice() Date: Mon, 24 Jun 2013 20:11:47 +0200 Message-Id: X-Mailer: git-send-email 1.8.1.2 In-Reply-To: References: In-Reply-To: References: Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sedat Dilek This is a cleanup which uses the proper (new) definitions and does not change current behaviour. Signed-off-by: Sedat Dilek Reviewed-by: "Yann E. MORIN" Tested-by: "Yann E. MORIN" Signed-off-by: "Yann E. MORIN" --- Yann had some more ideas on improvements: "What would be nice is an improvement that scales the choice window to the number of entries in the choice. If there are a lot of choice entries, then the choice popup grows in height (but does not overflow the screen of course). So, instead of seeing only 6 entries, we'd see as much as possible in the current screen. Ditto for the width: the popup adapts to the longest prompt (but does not overflow the screen either, of course), so prompts are not truncated." NOTE: This patch requires [1]. [1] http://marc.info/?l=linux-kbuild&m=137128726917166&w=2 --- scripts/kconfig/mconf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c index 387dc8d..2396c5b 100644 --- a/scripts/kconfig/mconf.c +++ b/scripts/kconfig/mconf.c @@ -825,7 +825,9 @@ static void conf_choice(struct menu *menu) dialog_clear(); res = dialog_checklist(prompt ? _(prompt) : _("Main Menu"), _(radiolist_instructions), - 15, 70, 6); + MENUBOX_HEIGTH_MIN, + MENUBOX_WIDTH_MIN, + CHECKLIST_HEIGTH_MIN); selected = item_activate_selected(); switch (res) { case 0: