From patchwork Wed Sep 13 17:01:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Palmer Dabbelt X-Patchwork-Id: 9951681 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9A82260360 for ; Wed, 13 Sep 2017 17:01:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 880D028C64 for ; Wed, 13 Sep 2017 17:01:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C58F28C68; Wed, 13 Sep 2017 17:01:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA65F28C64 for ; Wed, 13 Sep 2017 17:01:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751111AbdIMRBr (ORCPT ); Wed, 13 Sep 2017 13:01:47 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:38498 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdIMRBq (ORCPT ); Wed, 13 Sep 2017 13:01:46 -0400 Received: by mail-pg0-f67.google.com with SMTP id m30so369453pgn.5 for ; Wed, 13 Sep 2017 10:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=date:subject:in-reply-to:cc:from:to:message-id:mime-version; bh=s/rSN7vEQeGaB3QBdKC53DbliVGFoaWTqH6o8gsTIwE=; b=JewN83MA7ud2WnfgLP10jokN9oOr6znEy0Id4hOq/c7wXVLZqQQwGIJC+jO/xEvEEb vwGswPleSGhqcVleQDg+1BOVDVJBFs4u/oybACpUuk9DKMV6O4VUaHC8PPiso5RLCpPA MzIZBrNzLYyvmZs+aWgE2c8XphkLtUxSvZbg/FtlzuNN5Bw3qcz4RyDnDKyQDbkWDHis LkFiVAWhsu6Br8Y36lwDdwV9E6tjm2D0H8YB6RQvvE1Ize8yWg/+rFJeJqVMAFfq4YnD TIFHv1Bidk9g1DQ6rNpLWxDCBpONAcnUTbK7zcJZdcWWSQsD6ZbO2+psIwCfoQK+Ohwt tG+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:subject:in-reply-to:cc:from:to:message-id :mime-version; bh=s/rSN7vEQeGaB3QBdKC53DbliVGFoaWTqH6o8gsTIwE=; b=Xrf1Se/Rk6FKcVF/mF6FZHRGW8R9phyHHCm9uft3IpjNzJFmbV7eGouo7sMs8tGi5T LN2J59lrS7ad1Kg9/KbkQ5oL+OWv73wqry8zbQd3QcWbBcljzXPvb/dVU3E+M+wIZu1w 02hIIxVoj3xZQ2q0BV+7JyJ+7IdBBTJAJRIjIDAFYWdVWL3iEb1lAhqQaTbg1jUROwn2 9M7HXN62zlhxQZOOT2YduM+43LnZs4NtxLUS/Zc/eOTGB4UK+31Txo4bC/E2HA52F94e dN+Dr74ViVGVkX1s37kFDvEsdzuX/pkeT9M7YLR3FH+6Ky98brzuNYld1iHbULnuRRpN 33Vw== X-Gm-Message-State: AHPjjUiCHVelrBe64X7Zgw3jwPZhx+bMuZcSqKQnMF8HDqV7kTodxPvO OX2Vc0UqZT3OeJ68 X-Google-Smtp-Source: ADKCNb6EXJO0PXjxHjEGDxYrKXSBTDaGdVX4gJvrdcZKF1Hm8bV4OJb8uR2VuEclFCfAjR1qMqKGYA== X-Received: by 10.84.130.97 with SMTP id 88mr21752747plc.138.1505322105905; Wed, 13 Sep 2017 10:01:45 -0700 (PDT) Received: from localhost ([12.206.222.5]) by smtp.gmail.com with ESMTPSA id h70sm25681330pfc.115.2017.09.13.10.01.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Sep 2017 10:01:44 -0700 (PDT) Date: Wed, 13 Sep 2017 10:01:44 -0700 (PDT) X-Google-Original-Date: Wed, 13 Sep 2017 09:44:33 PDT (-0700) Subject: Re: [PATCH v8 10/18] RISC-V: Init and Halt Code In-Reply-To: CC: peterz@infradead.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, dmitriy@oss-tech.org, yamada.masahiro@socionext.com, mmarek@suse.com, albert@sifive.com, will.deacon@arm.com, boqun.feng@gmail.com, oleg@redhat.com, mingo@redhat.com, daniel.lezcano@linaro.org, gregkh@linuxfoundation.org, jslaby@suse.com, davem@davemloft.net, mchehab@kernel.org, hverkuil@xs4all.nl, rdunlap@infradead.org, viro@zeniv.linux.org.uk, mhiramat@kernel.org, fweisbec@gmail.com, mcgrof@kernel.org, dledford@redhat.com, bart.vanassche@sandisk.com, sstabellini@kernel.org, mpe@ellerman.id.au, rmk+kernel@armlinux.org.uk, paul.gortmaker@windriver.com, nicolas.dichtel@6wind.com, linux@roeck-us.net, heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, geert@linux-m68k.org, akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, jiri@mellanox.com, vgupta@synopsys.com, airlied@redhat.com, jk@ozlabs.org, chris@chris-wilson.co.uk, Jason@zx2c4.com, paulmck@linux.vnet.ibm.com, ncardwell@google.com, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, patches@groups.riscv.org From: Palmer Dabbelt To: Arnd Bergmann Message-ID: Mime-Version: 1.0 (MHng) Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 13 Sep 2017 08:20:42 PDT (-0700), Arnd Bergmann wrote: > On Tue, Sep 12, 2017 at 11:57 PM, Palmer Dabbelt wrote: >> This contains the various __init C functions, the initial assembly >> kernel entry point, and the code to reset the system. When a file was >> init-related this patch contains the entire file. > > One minor comment: > >> + /* >> + * This hart didn't win the lottery, so we wait for the winning hart to >> + * get far enough along the boot process that it should continue. >> + */ >> +.Lwait_for_cpu_up: >> + REG_L sp, (a1) >> + REG_L tp, (a2) >> + beqz sp, .Lwait_for_cpu_up >> + beqz tp, .Lwait_for_cpu_up >> + fence > > We usually discourage having the CPUs spin in a busy-loop while > waiting to be started up, at least on ARM platforms. It seems that > you could however just have them wait for an interrupt before checking > the sp/tp values. Would that guarantee to put the CPUs in a low > power state? There's no way to _force_ a core to go into a low power state, but putting a WFI (Wait For Interrupt) in there would at least allow implementations that care to save power. We already have some WFIs elsewhere, so it's the right thing to do here. There's a few sticky bits here: * WFI can be implemented as a noop, so this could race with other IPI handling. I think it's safe: our IPI is just a "maybe there's a new message" signal, so if there's a spurious one it's ignored. * Interrupts are disabled at this time, though since there's no trap vector it should be safe to enable them with a local trap vector here. I added a FIXME for now, I'll fix it by the v9. --- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/riscv/kernel/head.S b/arch/riscv/kernel/head.S index 1c50fe3765b1..76af908f87c1 100644 --- a/arch/riscv/kernel/head.S +++ b/arch/riscv/kernel/head.S @@ -130,6 +130,7 @@ relocate: * get far enough along the boot process that it should continue. */ .Lwait_for_cpu_up: + /* FIXME: We should WFI to save some energy here. */ REG_L sp, (a1) REG_L tp, (a2) beqz sp, .Lwait_for_cpu_up