mbox series

[v4,0/4] Fix some issues about kmod

Message ID 1587452704-1299-1-git-send-email-yangtiezhu@loongson.cn (mailing list archive)
Headers show
Series Fix some issues about kmod | expand

Message

Tiezhu Yang April 21, 2020, 7:05 a.m. UTC
v4:
  - update the commit message with application of patch 3/4

v3:
  - use the quotes with correct format in the commit message of patch 4/4,
    sorry for that

v2:
  - update the commit message to explain the detailed reason of patch 3/4
  - add this cover letter

Tiezhu Yang (4):
  selftests: kmod: Use variable NAME in kmod_test_0001()
  kmod: Remove redundant "be an" in the comment
  kmod: Return directly if module name is empty in request_module()
  test_kmod: Avoid potential double free in trigger_config_run_type()

 kernel/kmod.c                        | 10 +++++++---
 lib/test_kmod.c                      |  2 +-
 tools/testing/selftests/kmod/kmod.sh |  4 ++--
 3 files changed, 10 insertions(+), 6 deletions(-)

Comments

Tiezhu Yang May 11, 2020, 12:59 p.m. UTC | #1
Hi,

Could you please apply the following three patches?

[v4,1/4] selftests: kmod: Use variable NAME in kmod_test_0001()
https://lore.kernel.org/patchwork/patch/1227980/

[v4,2/4] kmod: Remove redundant "be an" in the comment
https://lore.kernel.org/patchwork/patch/1227982/

[v4,4/4] test_kmod: Avoid potential double free in trigger_config_run_type()
https://lore.kernel.org/patchwork/patch/1227978/

Thanks,
Tiezhu Yang
Luis Chamberlain May 11, 2020, 6:28 p.m. UTC | #2
On Mon, May 11, 2020 at 08:59:37PM +0800, Tiezhu Yang wrote:
> Hi,
> 
> Could you please apply the following three patches?
> 
> [v4,1/4] selftests: kmod: Use variable NAME in kmod_test_0001()
> https://lore.kernel.org/patchwork/patch/1227980/
> 
> [v4,2/4] kmod: Remove redundant "be an" in the comment
> https://lore.kernel.org/patchwork/patch/1227982/
> 
> [v4,4/4] test_kmod: Avoid potential double free in trigger_config_run_type()
> https://lore.kernel.org/patchwork/patch/1227978/

Andrew,

These 3 patches should be fine.

I am re-working a replacement proper fix for patch #3, that requires a
change to the umh. I'll try to iron this out today.

  Luis
Luis Chamberlain June 10, 2020, 2:33 a.m. UTC | #3
On Mon, May 11, 2020 at 12:28 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> On Mon, May 11, 2020 at 08:59:37PM +0800, Tiezhu Yang wrote:
> > Hi,
> >
> > Could you please apply the following three patches?
> >
> > [v4,1/4] selftests: kmod: Use variable NAME in kmod_test_0001()
> > https://lore.kernel.org/patchwork/patch/1227980/
> >
> > [v4,2/4] kmod: Remove redundant "be an" in the comment
> > https://lore.kernel.org/patchwork/patch/1227982/
> >
> > [v4,4/4] test_kmod: Avoid potential double free in trigger_config_run_type()
> > https://lore.kernel.org/patchwork/patch/1227978/
>
> Andrew,
>
> These 3 patches should be fine.
>
> I am re-working a replacement proper fix for patch #3, that requires a
> change to the umh. I'll try to iron this out today.

I'll pick these up, and run tests now that I have a finalized solution
in place for the patch replacement I mentioned which was needed. Sorry
this took so long, but I am glad I took my time. I'll post soon after
I test the new fix.

  Luis