mbox series

[bpf-next,v2,RESEND,0/2] Move bpf_printk to bpf_helpers.h

Message ID 20190523125355.18437-1-mrostecki@opensuse.org (mailing list archive)
Headers show
Series Move bpf_printk to bpf_helpers.h | expand

Message

Michal Rostecki May 23, 2019, 12:53 p.m. UTC
This series of patches move the commonly used bpf_printk macro to
bpf_helpers.h which is already included in all BPF programs which
defined that macro on their own.

v1->v2:
- If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set
  an empty macro for it.

Michal Rostecki (2):
  selftests: bpf: Move bpf_printk to bpf_helpers.h
  samples: bpf: Do not define bpf_printk macro

 samples/bpf/hbm_kern.h                                | 11 ++---------
 samples/bpf/tcp_basertt_kern.c                        |  7 -------
 samples/bpf/tcp_bufs_kern.c                           |  7 -------
 samples/bpf/tcp_clamp_kern.c                          |  7 -------
 samples/bpf/tcp_cong_kern.c                           |  7 -------
 samples/bpf/tcp_iw_kern.c                             |  7 -------
 samples/bpf/tcp_rwnd_kern.c                           |  7 -------
 samples/bpf/tcp_synrto_kern.c                         |  7 -------
 samples/bpf/tcp_tos_reflect_kern.c                    |  7 -------
 samples/bpf/xdp_sample_pkts_kern.c                    |  7 -------
 tools/testing/selftests/bpf/bpf_helpers.h             |  8 ++++++++
 .../testing/selftests/bpf/progs/sockmap_parse_prog.c  |  7 -------
 .../selftests/bpf/progs/sockmap_tcp_msg_prog.c        |  7 -------
 .../selftests/bpf/progs/sockmap_verdict_prog.c        |  7 -------
 .../testing/selftests/bpf/progs/test_lwt_seg6local.c  |  7 -------
 tools/testing/selftests/bpf/progs/test_xdp_noinline.c |  7 -------
 tools/testing/selftests/bpf/test_sockmap_kern.h       |  7 -------
 17 files changed, 10 insertions(+), 114 deletions(-)

Comments

Yonghong Song May 23, 2019, 4:51 p.m. UTC | #1
On 5/23/19 5:53 AM, Michal Rostecki wrote:
> This series of patches move the commonly used bpf_printk macro to
> bpf_helpers.h which is already included in all BPF programs which
> defined that macro on their own.
> 
> v1->v2:
> - If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set
>    an empty macro for it.
> 
> Michal Rostecki (2):
>    selftests: bpf: Move bpf_printk to bpf_helpers.h
>    samples: bpf: Do not define bpf_printk macro
> 
>   samples/bpf/hbm_kern.h                                | 11 ++---------
>   samples/bpf/tcp_basertt_kern.c                        |  7 -------
>   samples/bpf/tcp_bufs_kern.c                           |  7 -------
>   samples/bpf/tcp_clamp_kern.c                          |  7 -------
>   samples/bpf/tcp_cong_kern.c                           |  7 -------
>   samples/bpf/tcp_iw_kern.c                             |  7 -------
>   samples/bpf/tcp_rwnd_kern.c                           |  7 -------
>   samples/bpf/tcp_synrto_kern.c                         |  7 -------
>   samples/bpf/tcp_tos_reflect_kern.c                    |  7 -------
>   samples/bpf/xdp_sample_pkts_kern.c                    |  7 -------
>   tools/testing/selftests/bpf/bpf_helpers.h             |  8 ++++++++
>   .../testing/selftests/bpf/progs/sockmap_parse_prog.c  |  7 -------
>   .../selftests/bpf/progs/sockmap_tcp_msg_prog.c        |  7 -------
>   .../selftests/bpf/progs/sockmap_verdict_prog.c        |  7 -------
>   .../testing/selftests/bpf/progs/test_lwt_seg6local.c  |  7 -------
>   tools/testing/selftests/bpf/progs/test_xdp_noinline.c |  7 -------
>   tools/testing/selftests/bpf/test_sockmap_kern.h       |  7 -------
>   17 files changed, 10 insertions(+), 114 deletions(-)

Ack for the whole series.
Acked-by: Yonghong Song <yhs@fb.com>
Alexei Starovoitov May 24, 2019, 8:49 p.m. UTC | #2
On Thu, May 23, 2019 at 9:52 AM Yonghong Song <yhs@fb.com> wrote:
>
>
>
> On 5/23/19 5:53 AM, Michal Rostecki wrote:
> > This series of patches move the commonly used bpf_printk macro to
> > bpf_helpers.h which is already included in all BPF programs which
> > defined that macro on their own.
> >
> > v1->v2:
> > - If HBM_DEBUG is not defined in hbm sample, undefine bpf_printk and set
> >    an empty macro for it.
> >
> > Michal Rostecki (2):
> >    selftests: bpf: Move bpf_printk to bpf_helpers.h
> >    samples: bpf: Do not define bpf_printk macro
> >
> >   samples/bpf/hbm_kern.h                                | 11 ++---------
> >   samples/bpf/tcp_basertt_kern.c                        |  7 -------
> >   samples/bpf/tcp_bufs_kern.c                           |  7 -------
> >   samples/bpf/tcp_clamp_kern.c                          |  7 -------
> >   samples/bpf/tcp_cong_kern.c                           |  7 -------
> >   samples/bpf/tcp_iw_kern.c                             |  7 -------
> >   samples/bpf/tcp_rwnd_kern.c                           |  7 -------
> >   samples/bpf/tcp_synrto_kern.c                         |  7 -------
> >   samples/bpf/tcp_tos_reflect_kern.c                    |  7 -------
> >   samples/bpf/xdp_sample_pkts_kern.c                    |  7 -------
> >   tools/testing/selftests/bpf/bpf_helpers.h             |  8 ++++++++
> >   .../testing/selftests/bpf/progs/sockmap_parse_prog.c  |  7 -------
> >   .../selftests/bpf/progs/sockmap_tcp_msg_prog.c        |  7 -------
> >   .../selftests/bpf/progs/sockmap_verdict_prog.c        |  7 -------
> >   .../testing/selftests/bpf/progs/test_lwt_seg6local.c  |  7 -------
> >   tools/testing/selftests/bpf/progs/test_xdp_noinline.c |  7 -------
> >   tools/testing/selftests/bpf/test_sockmap_kern.h       |  7 -------
> >   17 files changed, 10 insertions(+), 114 deletions(-)
>
> Ack for the whole series.
> Acked-by: Yonghong Song <yhs@fb.com>

Applied. Thanks