| Message ID | 20211005234459.430873-1-michael.roth@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | KVM: selftests: Add tests for SEV, SEV-ES, and SEV-SNP guests | expand |
On 06/10/21 01:44, Michael Roth wrote: > These patches and are also available at: > > https://github.com/mdroth/linux/commits/sev-selftests-rfc1 > > They are based on top of v5 of Brijesh's SEV-SNP hypervisor patches[1] > to allow for SEV-SNP testing and provide some context for the overall > design, but the SEV/SEV-ES patches can be carved out into a separate > series as needed. > > == OVERVIEW == > > This series introduces a set of memory encryption-related parameter/hooks > in the core kselftest library, then uses the hooks to implement a small > library for creating/managing SEV, SEV-ES, SEV-SNP guests. This library > is then used to implement a basic boot/memory test that's run for all > variants of SEV/SEV-ES/SEV-SNP guest types, as well as a set of SEV-SNP > tests that cover various permutations of pvalidate/page-state changes. > > - Patches 1-7 implement SEV boot tests and should run against existing > kernels > - Patch 8 is a KVM changes that's required to allow SEV-ES/SEV-SNP > guests to boot with an externally generated page table, and is a > host kernel prequisite for the remaining patches in the series. > - Patches 9-12 extend the boot tests to cover SEV-ES > - Patches 13-16 extend the boot testst to cover SEV-SNP, and introduce > an additional test for page-state changes. Hi Mike, this SEV/SEV-ES testing (both your series and kvm-unit-tests) is good stuff. :) If you fix up patches 1-12, I will commit them pretty much straight away. The only thing that possibly needs some thought is the integration with ucall. Thanks, Paolo > Any review/comments are greatly appreciated! > > [1] https://lore.kernel.org/linux-mm/20210820155918.7518-1-brijesh.singh@amd.com/ > > ---------------------------------------------------------------- > Michael Roth (16): > KVM: selftests: move vm_phy_pages_alloc() earlier in file > KVM: selftests: add hooks for managing encrypted guest memory > KVM: selftests: handle encryption bits in page tables > KVM: selftests: set CPUID before setting sregs in vcpu creation > KVM: selftests: add support for encrypted vm_vaddr_* allocations > KVM: selftests: add library for creating/interacting with SEV guests > KVM: selftests: add SEV boot tests > KVM: SVM: include CR3 in initial VMSA state for SEV-ES guests > KVM: selftests: account for error code in #VC exception frame > KVM: selftests: add support for creating SEV-ES guests > KVM: selftests: add library for handling SEV-ES-related exits > KVM: selftests: add SEV-ES boot tests > KVM: selftests: add support for creating SEV-SNP guests > KVM: selftests: add helpers for SEV-SNP-related instructions/exits > KVM: selftests: add SEV-SNP boot tests > KVM: selftests: add SEV-SNP tests for page-state changes > > arch/x86/include/asm/kvm-x86-ops.h | 1 + > arch/x86/include/asm/kvm_host.h | 1 + > arch/x86/kvm/svm/svm.c | 22 ++ > arch/x86/kvm/vmx/vmx.c | 8 + > arch/x86/kvm/x86.c | 3 +- > tools/testing/selftests/kvm/.gitignore | 2 + > tools/testing/selftests/kvm/Makefile | 3 + > tools/testing/selftests/kvm/include/kvm_util.h | 8 + > tools/testing/selftests/kvm/include/x86_64/sev.h | 70 ++++ > .../selftests/kvm/include/x86_64/sev_exitlib.h | 20 ++ > tools/testing/selftests/kvm/include/x86_64/svm.h | 35 ++ > .../selftests/kvm/include/x86_64/svm_util.h | 2 + > tools/testing/selftests/kvm/lib/kvm_util.c | 249 +++++++++----- > .../testing/selftests/kvm/lib/kvm_util_internal.h | 10 + > tools/testing/selftests/kvm/lib/x86_64/handlers.S | 4 +- > tools/testing/selftests/kvm/lib/x86_64/processor.c | 30 +- > tools/testing/selftests/kvm/lib/x86_64/sev.c | 381 +++++++++++++++++++++ > .../testing/selftests/kvm/lib/x86_64/sev_exitlib.c | 326 ++++++++++++++++++ > .../selftests/kvm/x86_64/sev_all_boot_test.c | 367 ++++++++++++++++++++ > .../selftests/kvm/x86_64/sev_snp_psc_test.c | 378 ++++++++++++++++++++ > 20 files changed, 1820 insertions(+), 100 deletions(-) > create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev.h > create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev_exitlib.h > create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev.c > create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev_exitlib.c > create mode 100644 tools/testing/selftests/kvm/x86_64/sev_all_boot_test.c > create mode 100644 tools/testing/selftests/kvm/x86_64/sev_snp_psc_test.c > > >
On Thu, Oct 21, 2021 at 06:48:24PM +0200, Paolo Bonzini wrote: > On 06/10/21 01:44, Michael Roth wrote: > > These patches and are also available at: > > > > https://github.com/mdroth/linux/commits/sev-selftests-rfc1 > > > > They are based on top of v5 of Brijesh's SEV-SNP hypervisor patches[1] > > to allow for SEV-SNP testing and provide some context for the overall > > design, but the SEV/SEV-ES patches can be carved out into a separate > > series as needed. > > > > == OVERVIEW == > > > > This series introduces a set of memory encryption-related parameter/hooks > > in the core kselftest library, then uses the hooks to implement a small > > library for creating/managing SEV, SEV-ES, SEV-SNP guests. This library > > is then used to implement a basic boot/memory test that's run for all > > variants of SEV/SEV-ES/SEV-SNP guest types, as well as a set of SEV-SNP > > tests that cover various permutations of pvalidate/page-state changes. > > > > - Patches 1-7 implement SEV boot tests and should run against existing > > kernels > > - Patch 8 is a KVM changes that's required to allow SEV-ES/SEV-SNP > > guests to boot with an externally generated page table, and is a > > host kernel prequisite for the remaining patches in the series. > > - Patches 9-12 extend the boot tests to cover SEV-ES > > - Patches 13-16 extend the boot testst to cover SEV-SNP, and introduce > > an additional test for page-state changes. > > Hi Mike, > > this SEV/SEV-ES testing (both your series and kvm-unit-tests) is good stuff. > :) If you fix up patches 1-12, I will commit them pretty much straight > away. The only thing that possibly needs some thought is the integration > with ucall. Hi Paolo, Glad to hear :) For v2 I'll work on getting SEV/SEV-ES broken out into a separate series with all the review comments addressed. Still a little unsure about the best way to address some things in patch #3, but outlined a tentative plan that hopefully seems reasonable. Can re-visit in v2 as well. Thanks! -Mike > > Thanks, > > Paolo > > > Any review/comments are greatly appreciated! > > > > [1] https://lore.kernel.org/linux-mm/20210820155918.7518-1-brijesh.singh@amd.com/ > > > > ---------------------------------------------------------------- > > Michael Roth (16): > > KVM: selftests: move vm_phy_pages_alloc() earlier in file > > KVM: selftests: add hooks for managing encrypted guest memory > > KVM: selftests: handle encryption bits in page tables > > KVM: selftests: set CPUID before setting sregs in vcpu creation > > KVM: selftests: add support for encrypted vm_vaddr_* allocations > > KVM: selftests: add library for creating/interacting with SEV guests > > KVM: selftests: add SEV boot tests > > KVM: SVM: include CR3 in initial VMSA state for SEV-ES guests > > KVM: selftests: account for error code in #VC exception frame > > KVM: selftests: add support for creating SEV-ES guests > > KVM: selftests: add library for handling SEV-ES-related exits > > KVM: selftests: add SEV-ES boot tests > > KVM: selftests: add support for creating SEV-SNP guests > > KVM: selftests: add helpers for SEV-SNP-related instructions/exits > > KVM: selftests: add SEV-SNP boot tests > > KVM: selftests: add SEV-SNP tests for page-state changes > > > > arch/x86/include/asm/kvm-x86-ops.h | 1 + > > arch/x86/include/asm/kvm_host.h | 1 + > > arch/x86/kvm/svm/svm.c | 22 ++ > > arch/x86/kvm/vmx/vmx.c | 8 + > > arch/x86/kvm/x86.c | 3 +- > > tools/testing/selftests/kvm/.gitignore | 2 + > > tools/testing/selftests/kvm/Makefile | 3 + > > tools/testing/selftests/kvm/include/kvm_util.h | 8 + > > tools/testing/selftests/kvm/include/x86_64/sev.h | 70 ++++ > > .../selftests/kvm/include/x86_64/sev_exitlib.h | 20 ++ > > tools/testing/selftests/kvm/include/x86_64/svm.h | 35 ++ > > .../selftests/kvm/include/x86_64/svm_util.h | 2 + > > tools/testing/selftests/kvm/lib/kvm_util.c | 249 +++++++++----- > > .../testing/selftests/kvm/lib/kvm_util_internal.h | 10 + > > tools/testing/selftests/kvm/lib/x86_64/handlers.S | 4 +- > > tools/testing/selftests/kvm/lib/x86_64/processor.c | 30 +- > > tools/testing/selftests/kvm/lib/x86_64/sev.c | 381 +++++++++++++++++++++ > > .../testing/selftests/kvm/lib/x86_64/sev_exitlib.c | 326 ++++++++++++++++++ > > .../selftests/kvm/x86_64/sev_all_boot_test.c | 367 ++++++++++++++++++++ > > .../selftests/kvm/x86_64/sev_snp_psc_test.c | 378 ++++++++++++++++++++ > > 20 files changed, 1820 insertions(+), 100 deletions(-) > > create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev.h > > create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev_exitlib.h > > create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev.c > > create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev_exitlib.c > > create mode 100644 tools/testing/selftests/kvm/x86_64/sev_all_boot_test.c > > create mode 100644 tools/testing/selftests/kvm/x86_64/sev_snp_psc_test.c > > > > > > >
On 25/10/21 06:27, Michael Roth wrote: > > Glad to hear:) For v2 I'll work on getting SEV/SEV-ES broken out into a > separate series with all the review comments addressed. Still a little > unsure about the best way to address some things in patch #3, but > outlined a tentative plan that hopefully seems reasonable. Can re-visit > in v2 as well. Sounds good, all I can do is point out things that seem "weird", but nothing beats the experience of actually working with the code. Paolo
These patches and are also available at: https://github.com/mdroth/linux/commits/sev-selftests-rfc1 They are based on top of v5 of Brijesh's SEV-SNP hypervisor patches[1] to allow for SEV-SNP testing and provide some context for the overall design, but the SEV/SEV-ES patches can be carved out into a separate series as needed. == OVERVIEW == This series introduces a set of memory encryption-related parameter/hooks in the core kselftest library, then uses the hooks to implement a small library for creating/managing SEV, SEV-ES, SEV-SNP guests. This library is then used to implement a basic boot/memory test that's run for all variants of SEV/SEV-ES/SEV-SNP guest types, as well as a set of SEV-SNP tests that cover various permutations of pvalidate/page-state changes. - Patches 1-7 implement SEV boot tests and should run against existing kernels - Patch 8 is a KVM changes that's required to allow SEV-ES/SEV-SNP guests to boot with an externally generated page table, and is a host kernel prequisite for the remaining patches in the series. - Patches 9-12 extend the boot tests to cover SEV-ES - Patches 13-16 extend the boot testst to cover SEV-SNP, and introduce an additional test for page-state changes. Any review/comments are greatly appreciated! [1] https://lore.kernel.org/linux-mm/20210820155918.7518-1-brijesh.singh@amd.com/ ---------------------------------------------------------------- Michael Roth (16): KVM: selftests: move vm_phy_pages_alloc() earlier in file KVM: selftests: add hooks for managing encrypted guest memory KVM: selftests: handle encryption bits in page tables KVM: selftests: set CPUID before setting sregs in vcpu creation KVM: selftests: add support for encrypted vm_vaddr_* allocations KVM: selftests: add library for creating/interacting with SEV guests KVM: selftests: add SEV boot tests KVM: SVM: include CR3 in initial VMSA state for SEV-ES guests KVM: selftests: account for error code in #VC exception frame KVM: selftests: add support for creating SEV-ES guests KVM: selftests: add library for handling SEV-ES-related exits KVM: selftests: add SEV-ES boot tests KVM: selftests: add support for creating SEV-SNP guests KVM: selftests: add helpers for SEV-SNP-related instructions/exits KVM: selftests: add SEV-SNP boot tests KVM: selftests: add SEV-SNP tests for page-state changes arch/x86/include/asm/kvm-x86-ops.h | 1 + arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/svm/svm.c | 22 ++ arch/x86/kvm/vmx/vmx.c | 8 + arch/x86/kvm/x86.c | 3 +- tools/testing/selftests/kvm/.gitignore | 2 + tools/testing/selftests/kvm/Makefile | 3 + tools/testing/selftests/kvm/include/kvm_util.h | 8 + tools/testing/selftests/kvm/include/x86_64/sev.h | 70 ++++ .../selftests/kvm/include/x86_64/sev_exitlib.h | 20 ++ tools/testing/selftests/kvm/include/x86_64/svm.h | 35 ++ .../selftests/kvm/include/x86_64/svm_util.h | 2 + tools/testing/selftests/kvm/lib/kvm_util.c | 249 +++++++++----- .../testing/selftests/kvm/lib/kvm_util_internal.h | 10 + tools/testing/selftests/kvm/lib/x86_64/handlers.S | 4 +- tools/testing/selftests/kvm/lib/x86_64/processor.c | 30 +- tools/testing/selftests/kvm/lib/x86_64/sev.c | 381 +++++++++++++++++++++ .../testing/selftests/kvm/lib/x86_64/sev_exitlib.c | 326 ++++++++++++++++++ .../selftests/kvm/x86_64/sev_all_boot_test.c | 367 ++++++++++++++++++++ .../selftests/kvm/x86_64/sev_snp_psc_test.c | 378 ++++++++++++++++++++ 20 files changed, 1820 insertions(+), 100 deletions(-) create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev.h create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev_exitlib.h create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev.c create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev_exitlib.c create mode 100644 tools/testing/selftests/kvm/x86_64/sev_all_boot_test.c create mode 100644 tools/testing/selftests/kvm/x86_64/sev_snp_psc_test.c