From patchwork Thu May 26 13:41:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 12862437 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F24C433EF for ; Thu, 26 May 2022 13:41:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240367AbiEZNlh (ORCPT ); Thu, 26 May 2022 09:41:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231466AbiEZNlg (ORCPT ); Thu, 26 May 2022 09:41:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 889BCC17 for ; Thu, 26 May 2022 06:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653572492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=psF/SAzkqXSB5iGV88JF4c0l1o2XBFHBME6W1tXw3ac=; b=WmN+hWqDJaxwIQvVTjCY2m/Yp238kPG2749mJpwm+oHxA1EgAXS4M8By/VfJUtTvLP5VTH zdzKy7oqyo47EWzxqtfVy8CijXVU7YjAHFRGdtbc2W8ciyxU0gFh2IGHRqnQsA8g5Y46M9 fAfItvu0P3RabK1hZBWUb2uyZcEPB9U= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-iw7EeIbVNpWAlbR9N7_k8w-1; Thu, 26 May 2022 09:41:31 -0400 X-MC-Unique: iw7EeIbVNpWAlbR9N7_k8w-1 Received: by mail-wm1-f69.google.com with SMTP id m19-20020a05600c4f5300b003974eba88c0so1099879wmq.9 for ; Thu, 26 May 2022 06:41:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=psF/SAzkqXSB5iGV88JF4c0l1o2XBFHBME6W1tXw3ac=; b=cG1dzmsZFB2BLZVuEmGqVgHz65PJNaNcT/BMWu3vfxHjHWnBcXOEcWMD9N+oiA7u2A 29SNjqCV3koHFfdCTjiPcOG/6ec93qd1zIwm3Tw5l8MEIdTNr/jBqBTe1eSaGkEUd9IL NW5Hq6nxLUA++63ZzbwY/PMzIPoo95vrUQui2/AVPXDNYRxyBnqml1iSy59mtOCQPFNs 1w8Y3wqLgmcael98SCmRZZY6DaP5NINjGDT3nsvySNK2lp1+MvyJ5en6DCAm4gTkyQVK kXM6UWwrO3uDxyMHc2lSLWFOGcWoOSh2tQve5eZRSeyKHhEepgGCnF63WCmGJ44nEjTC 6nzg== X-Gm-Message-State: AOAM531Jog843wbYfts46BOActNmNc1pFM5u4fvp8GS0odxj8MV5Xa93 ZS7v+tvQs3yEA6MNJ44dZAfnwg/v8UUlsHkZadGCzkSgsHk6uWchj/VDLBCcAVgWiE2LFCPIky/ /tYVytts1q7f6noOLZrjoArpJdYOc X-Received: by 2002:a05:600c:3583:b0:397:3d93:75b8 with SMTP id p3-20020a05600c358300b003973d9375b8mr2349324wmq.76.1653572490512; Thu, 26 May 2022 06:41:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytVlrrsRs5q4UkJKl030m3nelnOfkqzrldHtQRWFAJgXuye49B/o43k9DqzgJar7qeJweWgQ== X-Received: by 2002:a05:600c:3583:b0:397:3d93:75b8 with SMTP id p3-20020a05600c358300b003973d9375b8mr2349295wmq.76.1653572490088; Thu, 26 May 2022 06:41:30 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id h6-20020a5d5046000000b0020c547f75easm1765022wrt.101.2022.05.26.06.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 06:41:29 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Christian Kellner , Muhammad Usama Anjum , Alexander Larsson , Alberto Ruiz , Peter Jones , Lennart Poettering , Colin Walters , Chung-Chiang Cheng , Javier Martinez Canillas , OGAWA Hirofumi , Shuah Khan , linux-kselftest@vger.kernel.org Subject: [PATCH v3 0/3] fat: add support for the renameat2 RENAME_EXCHANGE flag Date: Thu, 26 May 2022 15:41:16 +0200 Message-Id: <20220526134119.242182-1-javierm@redhat.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Hello, This series add support for the renameat2 system call RENAME_EXCHANGE flag (which allows to atomically replace two paths) to the vfat filesystem code. There are many use cases for this, but we are particularly interested in making possible for vfat filesystems to be part of OSTree [0] deployments. Currently OSTree relies on symbolic links to make the deployment updates an atomic transactional operation. But RENAME_EXCHANGE could be used [1] to achieve a similar level of robustness when using a vfat filesystem. Patch #1 is just a preparatory patch to introduce the RENAME_EXCHANGE support in patch #2 and finally patch #3 adds some kselftests to test it. This is a v3 that addresses issues pointed out in the second version posted: https://lkml.org/lkml/2022/5/24/137 [0]: https://github.com/ostreedev/ostree [1]: https://github.com/ostreedev/ostree/issues/1649 Changes in v3: - Add a .gitignore for the rename_exchange binary (Muhammad Usama Anjum). - Include $(KHDR_INCLUDES) instead of hardcoding a relative path in Makefile (Muhammad Usama Anjum). Changes in v2: - Only update the new_dir inode version and timestamps if != old_dir (Alex Larsson). - Add some helper functions to avoid duplicating code (OGAWA Hirofumi). - Use braces for multi-lines blocks even if are one statement (OGAWA Hirofumi). - Mention in commit message that the operation is as transactional as possible but within the vfat limitations of not having a journal (Colin Walters). - Call sync to flush the page cache before checking the file contents (Alex Larsson). - Drop RFC prefix since the patches already got some review. Javier Martinez Canillas (3): fat: add a vfat_rename2() and make existing .rename callback a helper fat: add renameat2 RENAME_EXCHANGE flag support selftests/filesystems: add a vfat RENAME_EXCHANGE test MAINTAINERS | 1 + fs/fat/namei_vfat.c | 193 +++++++++++++++++- tools/testing/selftests/Makefile | 1 + .../selftests/filesystems/fat/.gitignore | 2 + .../selftests/filesystems/fat/Makefile | 7 + .../testing/selftests/filesystems/fat/config | 2 + .../filesystems/fat/rename_exchange.c | 37 ++++ .../filesystems/fat/run_fat_tests.sh | 82 ++++++++ 8 files changed, 318 insertions(+), 7 deletions(-) create mode 100644 tools/testing/selftests/filesystems/fat/.gitignore create mode 100644 tools/testing/selftests/filesystems/fat/Makefile create mode 100644 tools/testing/selftests/filesystems/fat/config create mode 100644 tools/testing/selftests/filesystems/fat/rename_exchange.c create mode 100755 tools/testing/selftests/filesystems/fat/run_fat_tests.sh