mbox series

[v2,0/4] Some improvements of resctrl selftest

Message ID 20221005013933.1486054-1-tan.shaopeng@jp.fujitsu.com (mailing list archive)
Headers show
Series Some improvements of resctrl selftest | expand

Message

Shaopeng Tan Oct. 5, 2022, 1:39 a.m. UTC
Hello,

The aim of this patch series is to improve the resctrl selftest.
Without these fixes, some unnecessary processing will be executed
and test results will be confusing. 
There is no behavior change in test themselves.

[patch 1] Make write_schemata() run to set up shemata with 100% allocation
	  on first run in MBM test.
[patch 2] The MBA test result message is always output as "ok",
	  make output message to be "not ok" if MBA check result is failed.
[patch 3] Before exiting each test CMT/CAT/MBM/MBA, clear test result 
	  files function cat/cmt/mbm/mba_test_cleanup() are called
	  twice.  Delete once.
[patch 4] When a child process is created by fork(), the buffer of the 
	  parent process is also copied. Flush the buffer before
	  executing fork().

This patch series is based on Linux v6.0-rc7

Difference from v1:
[patch 1] Make write_schemata() always be called, and use 
	  resctrl_val_param->num_of_runs instead of static num_of_runs.
[patch 2] Add Reviewed-by tag.
[patch 3] Remove cat/cmt/mbm/mba_test_cleanup() from run_cmt/mbm/mba_test()
	  and modify changelog.
[patch 4] Add Reviewed-by tag.

Notice that I dropped the one patch from v1 in this series
("[PATCH 4/5] selftests/resctrl: Kill the child process before exiting
the parent process if an exception occurs").
This is because the bug will take some time to fix, I will submit it
separately in the future.

Shaopeng Tan (4):
  selftests/resctrl: Fix set up shemata with 100% allocation on first
    run in MBM test.
  selftests/resctrl: Return MBA check result and make it to output
    message
  selftests/resctrl: Remove duplicate codes that clear each test result
    file
  selftests/resctrl: Flush stdout file buffer before executing fork()

 tools/testing/selftests/resctrl/cat_test.c      | 1 +
 tools/testing/selftests/resctrl/mba_test.c      | 8 ++++----
 tools/testing/selftests/resctrl/mbm_test.c      | 6 +++---
 tools/testing/selftests/resctrl/resctrl_tests.c | 4 ----
 tools/testing/selftests/resctrl/resctrl_val.c   | 1 +
 tools/testing/selftests/resctrl/resctrlfs.c     | 1 +
 6 files changed, 10 insertions(+), 11 deletions(-)