From patchwork Thu Aug 3 07:28:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 13339362 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75819C04A6A for ; Thu, 3 Aug 2023 07:28:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232697AbjHCH24 (ORCPT ); Thu, 3 Aug 2023 03:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231347AbjHCH2w (ORCPT ); Thu, 3 Aug 2023 03:28:52 -0400 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCBCB273A; Thu, 3 Aug 2023 00:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1691047728; bh=yUN4esrnjSf2QnQqSCJ5RZKfG0ro2Q4ZXEhcrqDqpVQ=; h=From:Subject:Date:To:Cc:From; b=Rt7/42HbfJMXfH0q+rozysM+jqki+XD/tikWspdFlmN7e3zS736J9KKR/p+da3LN9 ESudZ4J4W6iDOoWCeWITo3FiZWL6K10Uxf3Ll1LkIfv1BdL3vYILDRAYLtGnufzMZb 6ezKVKeuo3THIwXhdR+gKxVvDBNFwR3Fpf7ukb8Q= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Subject: [PATCH v3 00/14] tools/nolibc: enable compiler warnings Date: Thu, 03 Aug 2023 09:28:44 +0200 Message-Id: <20230803-nolibc-warnings-v3-0-bcc1a096ae02@weissschuh.net> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIACxXy2QC/3XNyw6CMBCF4VchXVvTC1hw5XsYF71JJzHFdLBoC O9uYeNCXf4nmW9mgj6BR3KsZpJ8BoQhlpC7itigY+8puNJEMCGZkpzG4QbG0kmnCLFHag++VqK ttWWSlKt78ld4buL5UjoAjkN6bQ8yX9f/VuaUUVV3SjqhG+HUafKAiDY8wj76kaxgFh+kZT8QU RBudGN1o4zrzBeyLMsb6xL6BPgAAAA= To: Willy Tarreau , Shuah Khan Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Yuan Tan , Zhangjin Wu , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691047727; l=2437; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=yUN4esrnjSf2QnQqSCJ5RZKfG0ro2Q4ZXEhcrqDqpVQ=; b=TG485rZisHA4z6ZfIV+sunCuM4M9eteDd86I4C44cBu2QqtI+gX7t2nXHVhuEBmrQRw+4CMYU s5iSqLSTuOaDGVfVGddW9zXyZjfLJCHrmhduqepHMgYyVp9zfAu52DB X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org To help the developers to avoid mistakes and keep the code smaller let's enable compiler warnings. I stuck with __attribute__((unused)) over __maybe_unused in nolibc-test.c for consistency with nolibc proper. If we want to add a define it needs to be added twice once for nolibc proper and once for nolibc-test otherwise libc-test wouldn't build anymore. Signed-off-by: Thomas Weißschuh --- Changes in v3: - Make getpagesize() return "int" - Simplify validation of read() return value - Don't make functions static that are to be used as breakpoints - Drop -s from LDFLAGS - Use proper types for read()/write() return values - Fix unused parameter warnings in new setvbuf() - Link to v2: https://lore.kernel.org/r/20230801-nolibc-warnings-v2-0-1ba5ca57bd9b@weissschuh.net Changes in v2: - Don't drop unused test helpers, mark them as __attribute__((unused)) - Make some function in nolibc-test static - Also handle -W and -Wextra - Link to v1: https://lore.kernel.org/r/20230731-nolibc-warnings-v1-0-74973d2a52d7@weissschuh.net --- Thomas Weißschuh (14): tools/nolibc: drop unused variables tools/nolibc: fix return type of getpagesize() tools/nolibc: setvbuf: avoid unused parameter warnings tools/nolibc: sys: avoid implicit sign cast tools/nolibc: stdint: use int for size_t on 32bit selftests/nolibc: drop unused variables selftests/nolibc: mark test helpers as potentially unused selftests/nolibc: make functions static if possible selftests/nolibc: avoid unused parameter warnings selftests/nolibc: avoid sign-compare warnings selftests/nolibc: use correct return type for read() and write() selftests/nolibc: prevent out of bounds access in expect_vfprintf selftests/nolibc: don't strip nolibc-test selftests/nolibc: enable compiler warnings tools/include/nolibc/stdint.h | 4 + tools/include/nolibc/stdio.h | 5 +- tools/include/nolibc/sys.h | 7 +- tools/testing/selftests/nolibc/Makefile | 4 +- tools/testing/selftests/nolibc/nolibc-test.c | 111 ++++++++++++++++----------- 5 files changed, 80 insertions(+), 51 deletions(-) --- base-commit: bc87f9562af7b2b4cb07dcaceccfafcf05edaff8 change-id: 20230731-nolibc-warnings-c6e47284ac03 Best regards,