[v6,0/4] VM: selftests: Add LoongArch support

Message

maobibo Jan. 25, 2024, 1:54 a.m. UTC

This patchset adds KVM selftests for LoongArch system, currently only
some common test cases are supported and pass to run. These testcase
are listed as following: 
	demand_paging_test
	dirty_log_perf_test
	dirty_log_test
	guest_print_test
	hardware_disable_test
	kvm_binary_stats_test
	kvm_create_max_vcpus
	kvm_page_table_test
	memslot_modification_stress_test
	memslot_perf_test
	set_memory_region_test

This patchset originally is posted from zhaotianrui, I continue to work
on his efforts.

---
Changes in v6:
1. Refresh the patch based on latest kernel 6.8-rc1, add LoongArch
support about testcase set_memory_region_test.
2. Add hardware_disable_test test case.
3. Drop modification about macro DEFAULT_GUEST_TEST_MEM, it is problem
of LoongArch binutils, this issue is raised to LoongArch binutils owners.

Changes in v5:
1. In LoongArch kvm self tests, the DEFAULT_GUEST_TEST_MEM could be
0x130000000, it is different from the default value in memstress.h.
So we Move the definition of DEFAULT_GUEST_TEST_MEM into LoongArch
ucall.h, and add 'ifndef' condition for DEFAULT_GUEST_TEST_MEM
in memstress.h.

Changes in v4:
1. Remove the based-on flag, as the LoongArch KVM patch series
have been accepted by Linux kernel, so this can be applied directly
in kernel.

Changes in v3:
1. Improve implementation of LoongArch VM page walk.
2. Add exception handler for LoongArch.
3. Add dirty_log_test, dirty_log_perf_test, guest_print_test
test cases for LoongArch.
4. Add __ASSEMBLER__ macro to distinguish asm file and c file.
5. Move ucall_arch_do_ucall to the header file and make it as
static inline to avoid function calls.
6. Change the DEFAULT_GUEST_TEST_MEM base addr for LoongArch.

Changes in v2:
1. We should use ".balign 4096" to align the assemble code with 4K in
exception.S instead of "align 12".
2. LoongArch only supports 3 or 4 levels page tables, so we remove the
hanlders for 2-levels page table.
3. Remove the DEFAULT_LOONGARCH_GUEST_STACK_VADDR_MIN and use the common
DEFAULT_GUEST_STACK_VADDR_MIN to allocate stack memory in guest.
4. Reorganize the test cases supported by LoongArch.
5. Fix some code comments.
6. Add kvm_binary_stats_test test case into LoongArch KVM selftests.

---
Tianrui Zhao (4):
  KVM: selftests: Add KVM selftests header files for LoongArch
  KVM: selftests: Add core KVM selftests support for LoongArch
  KVM: selftests: Add ucall test support for LoongArch
  KVM: selftests: Add test cases for LoongArch

 tools/testing/selftests/kvm/Makefile          |  16 +
 .../selftests/kvm/include/kvm_util_base.h     |   5 +
 .../kvm/include/loongarch/processor.h         | 133 +++++++
 .../selftests/kvm/include/loongarch/ucall.h   |  20 ++
 .../selftests/kvm/lib/loongarch/exception.S   |  59 ++++
 .../selftests/kvm/lib/loongarch/processor.c   | 332 ++++++++++++++++++
 .../selftests/kvm/lib/loongarch/ucall.c       |  38 ++
 .../selftests/kvm/set_memory_region_test.c    |   2 +-
 8 files changed, 604 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/kvm/include/loongarch/processor.h
 create mode 100644 tools/testing/selftests/kvm/include/loongarch/ucall.h
 create mode 100644 tools/testing/selftests/kvm/lib/loongarch/exception.S
 create mode 100644 tools/testing/selftests/kvm/lib/loongarch/processor.c
 create mode 100644 tools/testing/selftests/kvm/lib/loongarch/ucall.c


base-commit: 7ed2632ec7d72e926b9e8bcc9ad1bb0cd37274bf

Comments

Sean Christopherson Jan. 26, 2024, 8:32 p.m. UTC | #1

On Thu, Jan 25, 2024, Bibo Mao wrote:
> ---
> Tianrui Zhao (4):
>   KVM: selftests: Add KVM selftests header files for LoongArch
>   KVM: selftests: Add core KVM selftests support for LoongArch
>   KVM: selftests: Add ucall test support for LoongArch
>   KVM: selftests: Add test cases for LoongArch
> 
>  tools/testing/selftests/kvm/Makefile          |  16 +
>  .../selftests/kvm/include/kvm_util_base.h     |   5 +
>  .../kvm/include/loongarch/processor.h         | 133 +++++++
>  .../selftests/kvm/include/loongarch/ucall.h   |  20 ++
>  .../selftests/kvm/lib/loongarch/exception.S   |  59 ++++
>  .../selftests/kvm/lib/loongarch/processor.c   | 332 ++++++++++++++++++
>  .../selftests/kvm/lib/loongarch/ucall.c       |  38 ++
>  .../selftests/kvm/set_memory_region_test.c    |   2 +-
>  8 files changed, 604 insertions(+), 1 deletion(-)
>  create mode 100644 tools/testing/selftests/kvm/include/loongarch/processor.h
>  create mode 100644 tools/testing/selftests/kvm/include/loongarch/ucall.h
>  create mode 100644 tools/testing/selftests/kvm/lib/loongarch/exception.S
>  create mode 100644 tools/testing/selftests/kvm/lib/loongarch/processor.c
>  create mode 100644 tools/testing/selftests/kvm/lib/loongarch/ucall.c

I did a *very* quick read through and didn't see anything egregious.  I really
hope that someday we can deduplicate much of the ARM/RISC-V/LoongArch code, but
that's no reason to hold up getting selftests support merged.

maobibo Jan. 29, 2024, 2:41 a.m. UTC | #2

On 2024/1/27 上午4:32, Sean Christopherson wrote:
> On Thu, Jan 25, 2024, Bibo Mao wrote:
>> ---
>> Tianrui Zhao (4):
>>    KVM: selftests: Add KVM selftests header files for LoongArch
>>    KVM: selftests: Add core KVM selftests support for LoongArch
>>    KVM: selftests: Add ucall test support for LoongArch
>>    KVM: selftests: Add test cases for LoongArch
>>
>>   tools/testing/selftests/kvm/Makefile          |  16 +
>>   .../selftests/kvm/include/kvm_util_base.h     |   5 +
>>   .../kvm/include/loongarch/processor.h         | 133 +++++++
>>   .../selftests/kvm/include/loongarch/ucall.h   |  20 ++
>>   .../selftests/kvm/lib/loongarch/exception.S   |  59 ++++
>>   .../selftests/kvm/lib/loongarch/processor.c   | 332 ++++++++++++++++++
>>   .../selftests/kvm/lib/loongarch/ucall.c       |  38 ++
>>   .../selftests/kvm/set_memory_region_test.c    |   2 +-
>>   8 files changed, 604 insertions(+), 1 deletion(-)
>>   create mode 100644 tools/testing/selftests/kvm/include/loongarch/processor.h
>>   create mode 100644 tools/testing/selftests/kvm/include/loongarch/ucall.h
>>   create mode 100644 tools/testing/selftests/kvm/lib/loongarch/exception.S
>>   create mode 100644 tools/testing/selftests/kvm/lib/loongarch/processor.c
>>   create mode 100644 tools/testing/selftests/kvm/lib/loongarch/ucall.c
> 
> I did a *very* quick read through and didn't see anything egregious.  I really
> hope that someday we can deduplicate much of the ARM/RISC-V/LoongArch code, but
> that's no reason to hold up getting selftests support merged.
> 
kvm seltests for LoongArch originally comes from ARM64, especially ucall 
and page table walk code. And LoongArch kvm actually benefits much from 
open source code, we will deduplicate some ARM/RISC-V/LoongArch kvm 
selftests code when LoongArch KVM is basically supported.

Regards
Bibo Mao