mbox series

[0/2] tracing/selftests: Verbosity improvements to KTAP output

Message ID 20240325-kselftest-ftrace-ktap-verbose-v1-0-3785199809da@kernel.org (mailing list archive)
Headers show
Series tracing/selftests: Verbosity improvements to KTAP output | expand

Message

Mark Brown March 25, 2024, 4:15 p.m. UTC
This series aims to improve the usability of the ftrace selftests when
running as part of the kselftest runner, mainly for use with automated
systems.  It fixes the output of verbose mode when run in KTAP output
mode and then enables verbose mode by default when invoked from the
kselftest runner so that the diagnostic information is there by default
when run in automated systems.

I've split this into two patches in case there is a concern with one
part but not the other, especially given the verbosity of the verbose
output when it triggers.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Mark Brown (2):
      tracing/selftests: Support log output when generating KTAP output
      tracing/selftests: Default to verbose mode when running in kselftest

 tools/testing/selftests/ftrace/ftracetest      | 8 +++++++-
 tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
 2 files changed, 8 insertions(+), 2 deletions(-)
---
base-commit: 4cece764965020c22cff7665b18a012006359095
change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213

Best regards,

Comments

Steven Rostedt March 26, 2024, 4:08 p.m. UTC | #1
Shuah,

If Masami is OK with this, can you take this through your tree?

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve


On Mon, 25 Mar 2024 16:15:49 +0000
Mark Brown <broonie@kernel.org> wrote:

> This series aims to improve the usability of the ftrace selftests when
> running as part of the kselftest runner, mainly for use with automated
> systems.  It fixes the output of verbose mode when run in KTAP output
> mode and then enables verbose mode by default when invoked from the
> kselftest runner so that the diagnostic information is there by default
> when run in automated systems.
> 
> I've split this into two patches in case there is a concern with one
> part but not the other, especially given the verbosity of the verbose
> output when it triggers.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> Mark Brown (2):
>       tracing/selftests: Support log output when generating KTAP output
>       tracing/selftests: Default to verbose mode when running in kselftest
> 
>  tools/testing/selftests/ftrace/ftracetest      | 8 +++++++-
>  tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> ---
> base-commit: 4cece764965020c22cff7665b18a012006359095
> change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213
> 
> Best regards,
Shuah Khan March 26, 2024, 7:11 p.m. UTC | #2
On 3/26/24 10:08, Steven Rostedt wrote:
> 
> Shuah,
> 
> If Masami is OK with this, can you take this through your tree?
> 
> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve
> 
> 

Yes. Will do once Masami gives me the okay.

> On Mon, 25 Mar 2024 16:15:49 +0000
> Mark Brown <broonie@kernel.org> wrote:
> 
>> This series aims to improve the usability of the ftrace selftests when
>> running as part of the kselftest runner, mainly for use with automated
>> systems.  It fixes the output of verbose mode when run in KTAP output
>> mode and then enables verbose mode by default when invoked from the
>> kselftest runner so that the diagnostic information is there by default
>> when run in automated systems.
>>
>> I've split this into two patches in case there is a concern with one
>> part but not the other, especially given the verbosity of the verbose
>> output when it triggers.
>>
>> Signed-off-by: Mark Brown <broonie@kernel.org>
>> ---
>> Mark Brown (2):
>>        tracing/selftests: Support log output when generating KTAP output
>>        tracing/selftests: Default to verbose mode when running in kselftest
>>
>>   tools/testing/selftests/ftrace/ftracetest      | 8 +++++++-
>>   tools/testing/selftests/ftrace/ftracetest-ktap | 2 +-
>>   2 files changed, 8 insertions(+), 2 deletions(-)
>> ---
>> base-commit: 4cece764965020c22cff7665b18a012006359095
>> change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213
>>
>> Best regards,
> 

thanks,
-- Shuah
Shuah Khan April 4, 2024, 4:32 p.m. UTC | #3
On 3/26/24 13:11, Shuah Khan wrote:
> On 3/26/24 10:08, Steven Rostedt wrote:
>>
>> Shuah,
>>
>> If Masami is OK with this, can you take this through your tree?
>>
>> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>>
>> -- Steve
>>
>>
> 
> Yes. Will do once Masami gives me the okay
Hi Masami,

Are you okay with this patch?

thanks,
-- Shuah
Masami Hiramatsu (Google) April 6, 2024, 12:36 p.m. UTC | #4
On Thu, 4 Apr 2024 10:32:33 -0600
Shuah Khan <skhan@linuxfoundation.org> wrote:

> On 3/26/24 13:11, Shuah Khan wrote:
> > On 3/26/24 10:08, Steven Rostedt wrote:
> >>
> >> Shuah,
> >>
> >> If Masami is OK with this, can you take this through your tree?
> >>
> >> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> >>
> >> -- Steve
> >>
> >>
> > 
> > Yes. Will do once Masami gives me the okay
> Hi Masami,
> 
> Are you okay with this patch?

Hi Shuah and Mark,

Sorry, I missed this series. This looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thank you!

> 
> thanks,
> -- Shuah
> 
>