mbox series

[v2,0/3] selftests/futex: clang-inspired fixes

Message ID 20240529022938.129624-1-jhubbard@nvidia.com (mailing list archive)
Headers show
Series selftests/futex: clang-inspired fixes | expand

Message

John Hubbard May 29, 2024, 2:29 a.m. UTC 
Hi,

Here's a few fixes that are part of my effort to get all selftests
building cleanly under clang. Plus one that I noticed by inspection.

Changes since the first version:

1) Rebased onto Linux 6.10-rc1
2) Added Reviewed-by's.

...and it turns out that all three patches are still required, on -rc1,
in order to get a clean clang build.

Enjoy!

thanks,
John Hubbard

John Hubbard (3):
  selftests/futex: don't redefine .PHONY targets (all, clean)
  selftests/futex: don't pass a const char* to asprintf(3)
  selftests/futex: pass _GNU_SOURCE without a value to the compiler

 tools/testing/selftests/futex/Makefile                      | 2 --
 tools/testing/selftests/futex/functional/Makefile           | 2 +-
 tools/testing/selftests/futex/functional/futex_requeue_pi.c | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)


base-commit: e0cce98fe279b64f4a7d81b7f5c3a23d80b92fbc

Comments

Shuah Khan May 30, 2024, 2:23 p.m. UTC | #1 
On 5/28/24 20:29, John Hubbard wrote:
> Hi,
> 
> Here's a few fixes that are part of my effort to get all selftests
> building cleanly under clang. Plus one that I noticed by inspection.
> 
> Changes since the first version:
> 
> 1) Rebased onto Linux 6.10-rc1
> 2) Added Reviewed-by's.
> 
> ...and it turns out that all three patches are still required, on -rc1,
> in order to get a clean clang build.

Thank you. I will apply these for the next rc.

thanks,
-- Shuah
Shuah Khan May 30, 2024, 7:09 p.m. UTC | #2 
On 5/30/24 08:23, Shuah Khan wrote:
> On 5/28/24 20:29, John Hubbard wrote:
>> Hi,
>>
>> Here's a few fixes that are part of my effort to get all selftests
>> building cleanly under clang. Plus one that I noticed by inspection.
>>
>> Changes since the first version:
>>
>> 1) Rebased onto Linux 6.10-rc1
>> 2) Added Reviewed-by's.
>>
>> ...and it turns out that all three patches are still required, on -rc1,
>> in order to get a clean clang build.
> 
> Thank you. I will apply these for the next rc.


John Hubbard (3):
   selftests/futex: don't redefine .PHONY targets (all, clean)
   selftests/futex: don't pass a const char* to asprintf(3)

Patch 1/3 and 2/3 please see changes requested.

Applied to linux-kselftest fixes branch
   selftests/futex: pass _GNU_SOURCE without a value to the compiler

thanks,
-- Shuah