mbox series

[bpf-next,v2,0/2] selftests/bpf: Enable vmtest for cross-compile arm64 on x86_64 host, and fix some issues.

Message ID 20240828121706.1721287-1-yikai.lin@vivo.com (mailing list archive)
Headers show
Series selftests/bpf: Enable vmtest for cross-compile arm64 on x86_64 host, and fix some issues. | expand

Message

Lin Yikai Aug. 28, 2024, 12:17 p.m. UTC
These two patch enable the use of "vmtest.sh" for cross-compile arm64 on x86_64 host.
This is essential for utilizing BPF on Android (arm64), 
as the compilation server is running on Ubuntu (x86).

Following previous guidance from V1, the two changes are as follow:

V2:
- patch 2:
   - [1/2] In Makefile, use $(SRCARCH) to get target arch's uapi.
           Therefore, there is no longer a need to compile "make headers_install".
   - [2/2] Regard "LDLIBS += -lzstd" as a separate patch for static compile.

v1:
   Link: https://lore.kernel.org/bpf/20240827133959.1269178-1-yikai.lin@vivo.com/
- patch 2:
   - [1/2] Update "vmtest.sh" for cross-compile arm64 on x86_64 host.
   - [2/2] Fix cross-compile issue for some files and a static compile issue for "-lzstd"

Lin Yikai (2):
  selftests/bpf: Enable vmtest for cross-compile arm64 on x86_64 host,
    and fix some related issues.
  selftests/bpf: fix static cross-compile error for liblstd.a linking.

 tools/testing/selftests/bpf/Makefile   |  8 +++++-
 tools/testing/selftests/bpf/README.rst | 11 +++++++-
 tools/testing/selftests/bpf/vmtest.sh  | 37 +++++++++++++++++++++-----
 3 files changed, 48 insertions(+), 8 deletions(-)

Comments

Andrii Nakryiko Sept. 5, 2024, 8:24 p.m. UTC | #1
On Wed, Aug 28, 2024 at 5:17 AM Lin Yikai <yikai.lin@vivo.com> wrote:
>
> These two patch enable the use of "vmtest.sh" for cross-compile arm64 on x86_64 host.
> This is essential for utilizing BPF on Android (arm64),
> as the compilation server is running on Ubuntu (x86).
>
> Following previous guidance from V1, the two changes are as follow:
>
> V2:
> - patch 2:
>    - [1/2] In Makefile, use $(SRCARCH) to get target arch's uapi.
>            Therefore, there is no longer a need to compile "make headers_install".
>    - [2/2] Regard "LDLIBS += -lzstd" as a separate patch for static compile.
>
> v1:
>    Link: https://lore.kernel.org/bpf/20240827133959.1269178-1-yikai.lin@vivo.com/
> - patch 2:
>    - [1/2] Update "vmtest.sh" for cross-compile arm64 on x86_64 host.
>    - [2/2] Fix cross-compile issue for some files and a static compile issue for "-lzstd"
>
> Lin Yikai (2):
>   selftests/bpf: Enable vmtest for cross-compile arm64 on x86_64 host,
>     and fix some related issues.
>   selftests/bpf: fix static cross-compile error for liblstd.a linking.
>
>  tools/testing/selftests/bpf/Makefile   |  8 +++++-
>  tools/testing/selftests/bpf/README.rst | 11 +++++++-
>  tools/testing/selftests/bpf/vmtest.sh  | 37 +++++++++++++++++++++-----
>  3 files changed, 48 insertions(+), 8 deletions(-)
>
> --
> 2.34.1
>
>

Given that [0] series was just applied and it also has some bits that
address cross-compilation, can you please rebase and re-check what
sort of changes you still need on top of that?

  [0] https://lore.kernel.org/all/20240905081401.1894789-1-pulehui@huaweicloud.com/