[kselftest,0/3] getrandom & chacha cleanups

Message

Jason A. Donenfeld Oct. 3, 2024, 3:13 a.m. UTC

Hi Shuah,

I've now read your email several times trying to figure out what you
meant and what your objections are. This series is my best attempt at
trying to satisfy that. But my understanding still has a lot of question
marks, so I may have missed your point here. Nonetheless, maybe this
moves things forward a bit.

Jason

Cc: Shuah Khan <[e-mail]>
Cc: Greg KH <[e-mail]>

Jason A. Donenfeld (3):
  selftests: vDSO: condition chacha build on chacha implementation
  selftests: vDSO: unconditionally build getrandom test
  selftests: vDSO: improve getrandom and chacha error messages

 tools/testing/selftests/vDSO/Makefile         |  4 +-
 .../testing/selftests/vDSO/vdso_test_chacha.c | 27 ++++---
 .../selftests/vDSO/vdso_test_getrandom.c      | 75 ++++++++-----------
 3 files changed, 52 insertions(+), 54 deletions(-)

Comments

Shuah Khan Oct. 3, 2024, 10:42 p.m. UTC | #1

On 10/2/24 21:13, Jason A. Donenfeld wrote:
> Hi Shuah,
> 
> I've now read your email several times trying to figure out what you
> meant and what your objections are. This series is my best attempt at
> trying to satisfy that. But my understanding still has a lot of question
> marks, so I may have missed your point here. Nonetheless, maybe this
> moves things forward a bit.
> 
> Jason
> 
> Cc: Shuah Khan <[e-mail]>
> Cc: Greg KH <[e-mail]>
> 
> Jason A. Donenfeld (3):
>    selftests: vDSO: condition chacha build on chacha implementation
>    selftests: vDSO: unconditionally build getrandom test
>    selftests: vDSO: improve getrandom and chacha error messages
> 
>   tools/testing/selftests/vDSO/Makefile         |  4 +-
>   .../testing/selftests/vDSO/vdso_test_chacha.c | 27 ++++---
>   .../selftests/vDSO/vdso_test_getrandom.c      | 75 ++++++++-----------
>   3 files changed, 52 insertions(+), 54 deletions(-)
> 

Thank you Jason for fixing the problem. The patches look good
to me. I will run some tests and apply all 4 patches for next rc.

I did review the 4th patch as well.
https://patchwork.kernel.org/project/linux-kselftest/patch/[e-mail]/

than