mbox series

[0/4] selftests: kvm: fscanf warn fixes and cleanups

Message ID cover.1631737524.git.skhan@linuxfoundation.org (mailing list archive)
Headers show
Series selftests: kvm: fscanf warn fixes and cleanups | expand

Message

Shuah Khan Sept. 15, 2021, 9:28 p.m. UTC
This patch series fixes fscanf() ignoring return value warnings.
Consolidates get_run_delay() duplicate defines moving it to
common library.

Shuah Khan (4):
  selftests:kvm: fix get_warnings_count() ignoring fscanf() return warn
  selftests:kvm: fix get_trans_hugepagesz() ignoring fscanf() return
    warn
  selftests: kvm: move get_run_delay() into lib/test_util
  selftests: kvm: fix get_run_delay() ignoring fscanf() return warn

 .../testing/selftests/kvm/include/test_util.h |  3 +++
 tools/testing/selftests/kvm/lib/test_util.c   | 22 ++++++++++++++++++-
 tools/testing/selftests/kvm/steal_time.c      | 16 --------------
 .../selftests/kvm/x86_64/mmio_warning_test.c  |  3 ++-
 .../selftests/kvm/x86_64/xen_shinfo_test.c    | 15 -------------
 5 files changed, 26 insertions(+), 33 deletions(-)

Comments

Paolo Bonzini Sept. 15, 2021, 10:34 p.m. UTC | #1
On 15/09/21 23:28, Shuah Khan wrote:
> This patch series fixes fscanf() ignoring return value warnings.
> Consolidates get_run_delay() duplicate defines moving it to
> common library.
> 
> Shuah Khan (4):
>    selftests:kvm: fix get_warnings_count() ignoring fscanf() return warn
>    selftests:kvm: fix get_trans_hugepagesz() ignoring fscanf() return
>      warn
>    selftests: kvm: move get_run_delay() into lib/test_util
>    selftests: kvm: fix get_run_delay() ignoring fscanf() return warn
> 
>   .../testing/selftests/kvm/include/test_util.h |  3 +++
>   tools/testing/selftests/kvm/lib/test_util.c   | 22 ++++++++++++++++++-
>   tools/testing/selftests/kvm/steal_time.c      | 16 --------------
>   .../selftests/kvm/x86_64/mmio_warning_test.c  |  3 ++-
>   .../selftests/kvm/x86_64/xen_shinfo_test.c    | 15 -------------
>   5 files changed, 26 insertions(+), 33 deletions(-)
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks Shuah!

Paolo
Shuah Khan Sept. 16, 2021, 12:02 a.m. UTC | #2
On 9/15/21 4:34 PM, Paolo Bonzini wrote:
> On 15/09/21 23:28, Shuah Khan wrote:
>> This patch series fixes fscanf() ignoring return value warnings.
>> Consolidates get_run_delay() duplicate defines moving it to
>> common library.
>>
>> Shuah Khan (4):
>>    selftests:kvm: fix get_warnings_count() ignoring fscanf() return warn
>>    selftests:kvm: fix get_trans_hugepagesz() ignoring fscanf() return
>>      warn
>>    selftests: kvm: move get_run_delay() into lib/test_util
>>    selftests: kvm: fix get_run_delay() ignoring fscanf() return warn
>>
>>   .../testing/selftests/kvm/include/test_util.h |  3 +++
>>   tools/testing/selftests/kvm/lib/test_util.c   | 22 ++++++++++++++++++-
>>   tools/testing/selftests/kvm/steal_time.c      | 16 --------------
>>   .../selftests/kvm/x86_64/mmio_warning_test.c  |  3 ++-
>>   .../selftests/kvm/x86_64/xen_shinfo_test.c    | 15 -------------
>>   5 files changed, 26 insertions(+), 33 deletions(-)
>>
> 
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Thanks Shuah!
> 

Thank you. I can take these through linux-kselftest - let me know
if that causes issues for kvm tree.

thanks,
-- Shuah
Paolo Bonzini Sept. 16, 2021, 5:06 a.m. UTC | #3
On 16/09/21 02:02, Shuah Khan wrote:
> On 9/15/21 4:34 PM, Paolo Bonzini wrote:
>> On 15/09/21 23:28, Shuah Khan wrote:
>>> This patch series fixes fscanf() ignoring return value warnings.
>>> Consolidates get_run_delay() duplicate defines moving it to
>>> common library.
>>>
>>> Shuah Khan (4):
>>>    selftests:kvm: fix get_warnings_count() ignoring fscanf() return warn
>>>    selftests:kvm: fix get_trans_hugepagesz() ignoring fscanf() return
>>>      warn
>>>    selftests: kvm: move get_run_delay() into lib/test_util
>>>    selftests: kvm: fix get_run_delay() ignoring fscanf() return warn
>>>
>>>   .../testing/selftests/kvm/include/test_util.h |  3 +++
>>>   tools/testing/selftests/kvm/lib/test_util.c   | 22 ++++++++++++++++++-
>>>   tools/testing/selftests/kvm/steal_time.c      | 16 --------------
>>>   .../selftests/kvm/x86_64/mmio_warning_test.c  |  3 ++-
>>>   .../selftests/kvm/x86_64/xen_shinfo_test.c    | 15 -------------
>>>   5 files changed, 26 insertions(+), 33 deletions(-)
>>>
>>
>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Thanks Shuah!
>>
> 
> Thank you. I can take these through linux-kselftest - let me know
> if that causes issues for kvm tree.

Go ahead if it's for 5.15-rc, I don't have any selftests patches pending.

Paolo
Shuah Khan Sept. 16, 2021, 6:31 p.m. UTC | #4
On 9/15/21 11:06 PM, Paolo Bonzini wrote:
> On 16/09/21 02:02, Shuah Khan wrote:
>> On 9/15/21 4:34 PM, Paolo Bonzini wrote:
>>> On 15/09/21 23:28, Shuah Khan wrote:
>>>> This patch series fixes fscanf() ignoring return value warnings.
>>>> Consolidates get_run_delay() duplicate defines moving it to
>>>> common library.
>>>>
>>>> Shuah Khan (4):
>>>>    selftests:kvm: fix get_warnings_count() ignoring fscanf() return warn
>>>>    selftests:kvm: fix get_trans_hugepagesz() ignoring fscanf() return
>>>>      warn
>>>>    selftests: kvm: move get_run_delay() into lib/test_util
>>>>    selftests: kvm: fix get_run_delay() ignoring fscanf() return warn
>>>>
>>>>   .../testing/selftests/kvm/include/test_util.h |  3 +++
>>>>   tools/testing/selftests/kvm/lib/test_util.c   | 22 ++++++++++++++++++-
>>>>   tools/testing/selftests/kvm/steal_time.c      | 16 --------------
>>>>   .../selftests/kvm/x86_64/mmio_warning_test.c  |  3 ++-
>>>>   .../selftests/kvm/x86_64/xen_shinfo_test.c    | 15 -------------
>>>>   5 files changed, 26 insertions(+), 33 deletions(-)
>>>>
>>>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>>
>>> Thanks Shuah!
>>>
>>
>> Thank you. I can take these through linux-kselftest - let me know
>> if that causes issues for kvm tree.
> 
> Go ahead if it's for 5.15-rc, I don't have any selftests patches pending.
> 

Thanks Paolo. I will apply these for rc3.

thanks,
-- Shuah