mbox series

[v2,0/2] tools/nolibc: add pipe(), pipe2() and their testcase

Message ID cover.1690733545.git.tanyuan@tinylab.org (mailing list archive)
Headers show
Series tools/nolibc: add pipe(), pipe2() and their testcase | expand

Message

Yuan Tan July 31, 2023, 5:50 a.m. UTC 
Hi, Willy, Thomas,

Thanks to your advice and I really learned a lot from it.

V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in test
case.

Best regards,
Yuan Tan

Yuan Tan (2):
  tools/nolibc: add pipe() and pipe2() support
  selftests/nolibc: add testcase for pipe

 tools/include/nolibc/sys.h                   | 24 ++++++++++++++
 tools/testing/selftests/nolibc/nolibc-test.c | 35 ++++++++++++++++++++
 2 files changed, 59 insertions(+)

Comments

Thomas Weißschuh July 31, 2023, 6:13 a.m. UTC | #1 
Hi Yuan!

On 2023-07-31 13:50:31+0800, Yuan Tan wrote:
> Thanks to your advice and I really learned a lot from it.
> 
> V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in test
> case.

Thanks!

I have some more comments for the patches.

For new revisions you should also link to the old revision.

> Best regards,
> Yuan Tan
> 
> Yuan Tan (2):
>   tools/nolibc: add pipe() and pipe2() support
>   selftests/nolibc: add testcase for pipe
> 
>  tools/include/nolibc/sys.h                   | 24 ++++++++++++++
>  tools/testing/selftests/nolibc/nolibc-test.c | 35 ++++++++++++++++++++
>  2 files changed, 59 insertions(+)
> 
> -- 
> 2.34.1
>
Yuan Tan July 31, 2023, 11:08 a.m. UTC | #2 
Hi Thomas,

On Mon, 2023-07-31 at 08:13 +0200, Thomas Weißschuh wrote:
> Hi Yuan!
> 
> On 2023-07-31 13:50:31+0800, Yuan Tan wrote:
> > Thanks to your advice and I really learned a lot from it.
> > 
> > V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in
> > test
> > case.
> 
> Thanks!
> 
> I have some more comments for the patches.
> 
> For new revisions you should also link to the old revision.
> 

I sincerely appreciate your valuable advice. As a newcomer, I will
certainly take note of it next time. :)

> > Best regards,
> > Yuan Tan
> > 
> > Yuan Tan (2):
> >   tools/nolibc: add pipe() and pipe2() support
> >   selftests/nolibc: add testcase for pipe
> > 
> >  tools/include/nolibc/sys.h                   | 24 ++++++++++++++
> >  tools/testing/selftests/nolibc/nolibc-test.c | 35
> > ++++++++++++++++++++
> >  2 files changed, 59 insertions(+)
> > 
> > -- 
> > 2.34.1
> > 
>