mbox series

[v3,0/2] tools/nolibc: add pipe(), pipe2() and their testcase

Message ID cover.1690903601.git.tanyuan@tinylab.org (mailing list archive)
Headers show
Series tools/nolibc: add pipe(), pipe2() and their testcase | expand

Message

Yuan Tan Aug. 1, 2023, 3:38 p.m. UTC 
Hi Willy and Thomas,

In v3, I have fixed all the problems you mentioned.

Welcome any other suggestion.

---
Changes in v3:
- Fix the missing return 
- Fix __NR_pipe to __NR_pipe2
- Fix the missing static
- Test case works in one process
- Link to v2:
  https://lore.kernel.org/all/cover.1690733545.git.tanyuan@tinylab.org

Changes in v2:
- Use sys_pipe2 to implement the pipe()
- Use memcmp() instead of strcmp()
- Link to v1:
  https://lore.kernel.org/all/cover.1690307717.git.tanyuan@tinylab.org

---
Yuan Tan (2):
  tools/nolibc: add pipe() and pipe2() support
  selftests/nolibc: add testcase for pipe

 tools/include/nolibc/sys.h                   | 24 ++++++++++++++++++++
 tools/testing/selftests/nolibc/nolibc-test.c | 22 ++++++++++++++++++
 2 files changed, 46 insertions(+)

Comments

Thomas Weißschuh Aug. 1, 2023, 3:42 p.m. UTC | #1 
Aug 1, 2023 17:40:01 Yuan Tan <tanyuan@tinylab.org>:

> Hi Willy and Thomas,
>
> In v3, I have fixed all the problems you mentioned.
>
> Welcome any other suggestion.
>
> ---
> Changes in v3:
> - Fix the missing return
> - Fix __NR_pipe to __NR_pipe2
> - Fix the missing static
> - Test case works in one process
> - Link to v2:
>   https://lore.kernel.org/all/cover.1690733545.git.tanyuan@tinylab.org
>
> Changes in v2:
> - Use sys_pipe2 to implement the pipe()
> - Use memcmp() instead of strcmp()
> - Link to v1:
>   https://lore.kernel.org/all/cover.1690307717.git.tanyuan@tinylab.org
>
> ---
> Yuan Tan (2):
>   tools/nolibc: add pipe() and pipe2() support
>   selftests/nolibc: add testcase for pipe
>
> tools/include/nolibc/sys.h                   | 24 ++++++++++++++++++++
> tools/testing/selftests/nolibc/nolibc-test.c | 22 ++++++++++++++++++
> 2 files changed, 46 insertions(+)

For the full series:

Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>

Thanks!
Willy Tarreau Aug. 1, 2023, 8:17 p.m. UTC | #2 
Hi,

On Tue, Aug 01, 2023 at 05:42:57PM +0200, Thomas Weißschuh  wrote:
> 
> Aug 1, 2023 17:40:01 Yuan Tan <tanyuan@tinylab.org>:
> 
> > Hi Willy and Thomas,
> >
> > In v3, I have fixed all the problems you mentioned.
> >
> > Welcome any other suggestion.
> >
> > ---
> > Changes in v3:
> > - Fix the missing return
> > - Fix __NR_pipe to __NR_pipe2
> > - Fix the missing static
> > - Test case works in one process
> > - Link to v2:
> >   https://lore.kernel.org/all/cover.1690733545.git.tanyuan@tinylab.org
> >
> > Changes in v2:
> > - Use sys_pipe2 to implement the pipe()
> > - Use memcmp() instead of strcmp()
> > - Link to v1:
> >   https://lore.kernel.org/all/cover.1690307717.git.tanyuan@tinylab.org
> >
> > ---
> > Yuan Tan (2):
> >   tools/nolibc: add pipe() and pipe2() support
> >   selftests/nolibc: add testcase for pipe
> >
> > tools/include/nolibc/sys.h                   | 24 ++++++++++++++++++++
> > tools/testing/selftests/nolibc/nolibc-test.c | 22 ++++++++++++++++++
> > 2 files changed, 46 insertions(+)
> 
> For the full series:
> 
> Reviewed-by: Thomas Weißschuh <linux@weissschuh.net>

Thank you both, now queued on top of the rest in 20230801-nolibc-next-1.
Thomas I'll try to review your last series tomorrow, at first glance it
looks OK.

Thanks,
Willy