mbox series

[bpf-next,v5,0/7] use network helpers, part 5

Message ID cover.1716638248.git.tanggeliang@kylinos.cn (mailing list archive)
Headers show
Series use network helpers, part 5 | expand

Message

Geliang Tang May 25, 2024, 12:08 p.m. UTC
From: Geliang Tang <tanggeliang@kylinos.cn>

This patchset uses post_socket_cb and post_connect_cb callbacks of struct
network_helper_opts to refactor do_test() in bpf_tcp_ca.c to move dctcp
test dedicated code out of do_test() into test_dctcp().

v5:
 - address Martin's comments in v4 (thanks)
 - add patch 4, use start_server_str in test_dctcp_fallback too
 - ASSERT_* is already used in settcpca, use this helper in cc_cb (patch 3)
 and stg_post_socket_cb (patch 6)
 - add ASSERT_* in stg_post_socket_cb in patch 6

v4:
 - address Martin's comments in v3 (thanks).
 - drop 2 patches, keep "type" as the individual arg to start_server_addr,
   connect_to_addr and start_server_str.

v3:
 - Add 4 new patches, 1-3 are cleanups. 4 adds a new helper.
 - address Martin's comments in v2.

v2:
 - rebased on commit "selftests/bpf: Add test for the use of new args in
 cong_control"

Geliang Tang (7):
  selftests/bpf: Drop struct post_socket_opts
  selftests/bpf: Add start_server_str helper
  selftests/bpf: Use post_socket_cb in connect_to_fd_opts
  selftests/bpf: Use post_socket_cb in start_server_str
  selftests/bpf: Use start_server_str in do_test in bpf_tcp_ca
  selftests/bpf: Use connect_to_fd_opts in do_test in bpf_tcp_ca
  selftests/bpf: Add post_connect_cb callback

 tools/testing/selftests/bpf/network_helpers.c |  39 +++--
 tools/testing/selftests/bpf/network_helpers.h |   9 +-
 .../selftests/bpf/prog_tests/bpf_tcp_ca.c     | 153 +++++++++++++-----
 .../bpf/prog_tests/sockopt_inherit.c          |   2 +-
 .../bpf/test_tcp_check_syncookie_user.c       |   4 +-
 5 files changed, 145 insertions(+), 62 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org May 29, 2024, 5:20 a.m. UTC | #1
Hello:

This series was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Sat, 25 May 2024 20:08:14 +0800 you wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This patchset uses post_socket_cb and post_connect_cb callbacks of struct
> network_helper_opts to refactor do_test() in bpf_tcp_ca.c to move dctcp
> test dedicated code out of do_test() into test_dctcp().
> 
> v5:
>  - address Martin's comments in v4 (thanks)
>  - add patch 4, use start_server_str in test_dctcp_fallback too
>  - ASSERT_* is already used in settcpca, use this helper in cc_cb (patch 3)
>  and stg_post_socket_cb (patch 6)
>  - add ASSERT_* in stg_post_socket_cb in patch 6
> 
> [...]

Here is the summary with links:
  - [bpf-next,v5,1/7] selftests/bpf: Drop struct post_socket_opts
    https://git.kernel.org/bpf/bpf-next/c/ed31adf6874d
  - [bpf-next,v5,2/7] selftests/bpf: Add start_server_str helper
    https://git.kernel.org/bpf/bpf-next/c/6f802cb8988e
  - [bpf-next,v5,3/7] selftests/bpf: Use post_socket_cb in connect_to_fd_opts
    https://git.kernel.org/bpf/bpf-next/c/e078255abd53
  - [bpf-next,v5,4/7] selftests/bpf: Use post_socket_cb in start_server_str
    https://git.kernel.org/bpf/bpf-next/c/79b330c57deb
  - [bpf-next,v5,5/7] selftests/bpf: Use start_server_str in do_test in bpf_tcp_ca
    https://git.kernel.org/bpf/bpf-next/c/ed61271af523
  - [bpf-next,v5,6/7] selftests/bpf: Use connect_to_fd_opts in do_test in bpf_tcp_ca
    (no matching commit)
  - [bpf-next,v5,7/7] selftests/bpf: Add post_connect_cb callback
    (no matching commit)

You are awesome, thank you!