| Message ID | cover.1721771340.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | use network helpers, part 11 | expand |
On Tue, Jul 23, 2024 at 3:22 PM Geliang Tang <geliang@kernel.org> wrote: > > From: Geliang Tang <tanggeliang@kylinos.cn> > > This set is part 11 of series "use network helpers" all BPF selftests > wide. > > Finally something new in this set. Geliang, See "Top scores (negative):" https://lore.kernel.org/bpf/ZqANgbFHX128IZYV@mini-arch/ you're the top spammer on this list. I strongly suggest you invest just as much time in reviewing other people's patches as sending yours or they will all be automatically rejected.
Hi Alexei, On Tue, 2024-07-23 at 17:04 -0700, Alexei Starovoitov wrote: > I strongly suggest you invest just as much time > in reviewing other people's patches as sending yours > or they will all be automatically rejected. Thanks for your reminder. I didn't know that our community has such a rule. I will try to reduce the number of iterations of my patches and the number of my emails sent to our community. I am very willing to review other people's patches, but I am only familiar with "BPF [SELFTESTS]" module. If possible, I would like to add myself (Geliang Tang <geliang@kernel.org>) as a reviewer of this module in MAINTAINERS so that I can receive emails of new patches for reviewing. Or please add this for me. Thanks, -Geliang
On Tue, Jul 23, 2024 at 7:07 PM Geliang Tang <geliang@kernel.org> wrote: > > Hi Alexei, > > On Tue, 2024-07-23 at 17:04 -0700, Alexei Starovoitov wrote: > > I strongly suggest you invest just as much time > > in reviewing other people's patches as sending yours > > or they will all be automatically rejected. > > Thanks for your reminder. I didn't know that our community has such a > rule. I will try to reduce the number of iterations of my patches and > the number of my emails sent to our community. Every patch submission has a cost. A reviewer and/or maintainer has to process it. You're sending way more than average, hence depleting the time reviewer/maintainers can spend on other submissions. This is not ok. > I am very willing to review other people's patches, but I am only > familiar with "BPF [SELFTESTS]" module. If possible, I would like to > add myself (Geliang Tang <geliang@kernel.org>) as a reviewer of this > module in MAINTAINERS so that I can receive emails of new patches for > reviewing. Or please add this for me. That's not how it works. Anyone can subscribe to bpf@vger and start reviewing patches. After some time when developers and maintainers see that a person commenting on the patches actually adding value then they will get recognized with R: or M: in the MAINTAINERS file.
On Tue, 2024-07-23 at 19:43 -0700, Alexei Starovoitov wrote: > On Tue, Jul 23, 2024 at 7:07 PM Geliang Tang <geliang@kernel.org> > wrote: > > > > Hi Alexei, > > > > On Tue, 2024-07-23 at 17:04 -0700, Alexei Starovoitov wrote: > > > I strongly suggest you invest just as much time > > > in reviewing other people's patches as sending yours > > > or they will all be automatically rejected. > > > > Thanks for your reminder. I didn't know that our community has such > > a > > rule. I will try to reduce the number of iterations of my patches > > and > > the number of my emails sent to our community. > > Every patch submission has a cost. A reviewer and/or maintainer > has to process it. You're sending way more than average, > hence depleting the time reviewer/maintainers can spend on other > submissions. This is not ok. > > > I am very willing to review other people's patches, but I am only > > familiar with "BPF [SELFTESTS]" module. If possible, I would like > > to > > add myself (Geliang Tang <geliang@kernel.org>) as a reviewer of > > this > > module in MAINTAINERS so that I can receive emails of new patches > > for > > reviewing. Or please add this for me. > > That's not how it works. Anyone can subscribe to bpf@vger and > start reviewing patches. > After some time when developers and maintainers see that > a person commenting on the patches actually adding value > then they will get recognized with R: or M: in the MAINTAINERS file. Got it, thanks for your explanation. -Geliang >
From: Geliang Tang <tanggeliang@kylinos.cn> This set is part 11 of series "use network helpers" all BPF selftests wide. Finally something new in this set. The helper make_sockaddr is extended to support sockets of AF_PACKET, AF_ALG and AF_VSOCK families. Then these types of sockets can be used to start_server_str() helper too. Imitating connect_to_* interfaces, send_to_* interfaces are added to support sendto() with given FD or the address string. Add more conditions to control listen: nolisten flag, listen_support() helper and clear "type" bits for listen. Patch 1 for AF_UNIX socket: Patch 1 uses start_server_str for a AF_UNIX socket. Patches 2-6 for AF_PACKET sockets: Patch 2 adds AF_PACKET support for make_sockaddr. Patch 3 uses start_server_str for a AF_PACKET socket. Patches 4-5 adds send_to_fd_opts/send_to_addr_str helpers. Patch 6 uses send_to_addr_str for a AF_PACKET socket. Patches 7-9 for AF_ALG sockets: Patch 7 adds AF_ALG support for make_sockaddr. Patch 8 add nolisten flag, needed by patch 9. Patch 9 uses send_to_addr_str for a AF_ALG socket. Patches 10-15 for AF_VSOCK sockets: Patch 10 adds AF_VSOCK support for make_sockaddr. Patches 11-12 uses make_sockaddr for AF_VSOCK sockets. Patches 13-14 adds more conditions to control listen. Patch 15 uses start_server_str for AF_VSOCK sockets. Geliang Tang (15): selftests/bpf: Use start_server_str in skc_to_unix_sock selftests/bpf: AF_PACKET support for make_sockaddr selftests/bpf: Use start_server_str in lwt_redirect selftests/bpf: Add send_to_fd_opts helper selftests/bpf: Add send_to_addr_str helper selftests/bpf: Use send_to_addr_str in xdp_bonding selftests/bpf: AF_ALG support for make_sockaddr selftests/bpf: Add nolisten for network_helper_opts selftests/bpf: Use start_server_str in crypto_sanity selftests/bpf: AF_VSOCK support for make_sockaddr selftests/bpf: Add loopback_addr_str helper selftests/bpf: Use make_sockaddr in sockmap_helpers selftests/bpf: Check listen support for start_server_addr selftests/bpf: Clear type bits for start_server_addr selftests/bpf: Use start_server_str in sockmap_helpers tools/testing/selftests/bpf/network_helpers.c | 144 +++++++++++++++--- tools/testing/selftests/bpf/network_helpers.h | 21 +++ .../selftests/bpf/prog_tests/crypto_sanity.c | 12 +- .../selftests/bpf/prog_tests/lwt_redirect.c | 21 +-- .../bpf/prog_tests/migrate_reuseport.c | 2 +- .../bpf/prog_tests/skc_to_unix_sock.c | 22 +-- .../bpf/prog_tests/sockmap_helpers.h | 101 +++--------- .../selftests/bpf/prog_tests/xdp_bonding.c | 20 +-- 8 files changed, 186 insertions(+), 157 deletions(-)