From patchwork Thu Jun 14 00:45:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ram Pai X-Patchwork-Id: 10463073 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3F015603EE for ; Thu, 14 Jun 2018 00:47:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31EA728988 for ; Thu, 14 Jun 2018 00:47:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 26BD128BA8; Thu, 14 Jun 2018 00:47:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CBABC28988 for ; Thu, 14 Jun 2018 00:47:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935869AbeFNArS (ORCPT ); Wed, 13 Jun 2018 20:47:18 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:35604 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936043AbeFNArR (ORCPT ); Wed, 13 Jun 2018 20:47:17 -0400 Received: by mail-qk0-f194.google.com with SMTP id d130-v6so2708297qkc.2; Wed, 13 Jun 2018 17:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=C4udlJABF5eeWZNs013FSwjyDB7eJazveNCvpjydk4w=; b=F74EpYzOmt869Z0pMV2duKoetV68qgN0DzvXrXioyxTkqCMO+Uw/lgjWiqlAdMYuYX MhtGJzHZzMPkEGPxi802KLjv8+efQ8SIueY3Ys5bGSAcAUB7edeQ2zgaipqtSZQR84g/ /t/PKBt0INxLo7gOwUtojTsOaJah9IMPQ+38kkVVp6DMAHUL12gtNnK6dcVIp8Dm/taP Mf6B9d4te9p/b6fVz9omRaD8ik/DTgi6QzqYRthCyFEEgorV5l/c5THylDwIIXigU5Az 5QuilHRkV6i3282bXQJjjXYY28zYauShFJaiXSdNuTOzh9HPmOEfJeGfCtuf9lz078tt nIOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=C4udlJABF5eeWZNs013FSwjyDB7eJazveNCvpjydk4w=; b=g8MM49msP83oMJvaLF/NxCT6NS9/O/5LFoq5+8XIuId2yys1aoaAMb/I5b1FoMf/2c mkw5jkz9z7eBuiQC9vDywVJm5IpvdNg6VhcfwL7KMOjaO4/aC0DgUJy1z8zcTGD4qDcW TYrCrmDstDNZGaErIvJygPtX8K4fPvkAkPRUpCCSpUu9n2eVdDuL9iWn0Y1uos4y/LjA Ux5FyPdR4onqc3jv6ia9OYTfT24WcrGkM9uFCol4B7aHaP6hjB5DhUwDov06Bxqmo8Cf aDfMWtDwWvPPh1zWg2hdczM6yaBT3lzJACIs1ZG4J4sHSi0Xv++AOVGP2FWj2rNefdL1 DIeQ== X-Gm-Message-State: APt69E0lPCL5XJJAvcBL55DmEDWM84+vf0A761s4hxNRGk0Hm2Z+EAV2 YWgsl2XnkCKuu4zc7JzIfaw= X-Google-Smtp-Source: ADUXVKI8heSsgXbdYStazmmEvjsEwjrqaZNqP8AFLtskasAHwSOavfpncgKO7owxU3qRb+lyRamWkQ== X-Received: by 2002:a37:17ea:: with SMTP id 103-v6mr315160qkx.373.1528937236408; Wed, 13 Jun 2018 17:47:16 -0700 (PDT) Received: from localhost.localdomain (50-39-100-161.bvtn.or.frontiernet.net. [50.39.100.161]) by smtp.gmail.com with ESMTPSA id u31-v6sm3225898qtc.28.2018.06.13.17.47.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jun 2018 17:47:16 -0700 (PDT) From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, dave.hansen@intel.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, linuxram@us.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Subject: [PATCH v13 16/24] selftests/vm: clear the bits in shadow reg when a pkey is freed. Date: Wed, 13 Jun 2018 17:45:07 -0700 Message-Id: <1528937115-10132-17-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> References: <1528937115-10132-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When a key is freed, the key is no more effective. Clear the bits corresponding to the pkey in the shadow register. Otherwise it will carry some spurious bits which can trigger false-positive asserts. cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index 88dfa40..ba184ca 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -577,7 +577,8 @@ int sys_pkey_free(unsigned long pkey) int ret = syscall(SYS_pkey_free, pkey); if (!ret) - shadow_pkey_reg &= clear_pkey_flags(pkey, PKEY_DISABLE_ACCESS); + shadow_pkey_reg &= clear_pkey_flags(pkey, + PKEY_DISABLE_ACCESS | PKEY_DISABLE_WRITE); dprintf1("%s(pkey=%ld) syscall ret: %d\n", __func__, pkey, ret); return ret; }