From patchwork Tue Jul 17 13:49:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ram Pai X-Patchwork-Id: 10529477 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4091B600F4 for ; Tue, 17 Jul 2018 13:50:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27BC229087 for ; Tue, 17 Jul 2018 13:50:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1B9772921E; Tue, 17 Jul 2018 13:50:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB6BD29087 for ; Tue, 17 Jul 2018 13:50:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731701AbeGQOXP (ORCPT ); Tue, 17 Jul 2018 10:23:15 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:43574 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731691AbeGQOXO (ORCPT ); Tue, 17 Jul 2018 10:23:14 -0400 Received: by mail-qt0-f193.google.com with SMTP id f18-v6so880987qtp.10; Tue, 17 Jul 2018 06:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=EcR3SDmB0WV2XGlTEZwt9KVPitnK5134qlvUDtzoqfA=; b=g/z/ucCpwLvVJ58dVBBLdnzlKDwFycSwj6eSl2XbH3RCjOxlF1ghl+yTEngxMfIe5q 8vp2Vcy/Oi9Vpmqi9fB9BAHx9tCqMXn9iJFmyfNQyDiD3+mDu8AxznanTJiaPFTbXOKf +CMSCHLA1DMq4lDnvyNQguujKueJHLDxT8ri2hDbo35a1oinL+2zX4X705i2aps2R0NE h5Qq+14BFClJlqzjzOGLpFel1sNcN2UuUwZwKCM9E69yHGKHf+m7v185m/sRelLhraeT rKSPRRyBqrg0lQ2ZEEK2HpFHI+iWEPg0L9zmqZVRQlqp3OVaqAJ1K/YbP6owICiaqHGN 5Gog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=EcR3SDmB0WV2XGlTEZwt9KVPitnK5134qlvUDtzoqfA=; b=RYIW3XHPE9SVkHJom7nPEvRkeJ615S5AkACQXBuTbE6rr0rqrJa9m7gJ3EMtgQFqvK jciGHCVCU9A7I/kPOzF+XjLEYZWGekwZf/f/zwmwCnnKBmT7K1Fujx9Tu26qpjGqsXVg MDIRhc4VrrYK0cOFEi7V8YivxYi5h1APhJOGb4bdN8u0swGHXEBqs3YznbuQ4odMOsN7 rf8mkIIUOnU8wJ2HjsIx/S6U2gAiNg///9oXUSgwWV7e4Tx1CSZBasgxLtsDQAlLf+3E ZRK84STfFucrsXwzVbrsILgJeG2P0FLsIZXh0Y6qphANh75gOG0StI1Bpg4W8euRk/Ve /NPQ== X-Gm-Message-State: AOUpUlE/WJYLinWV/vdSuZO2KVAVGNrxuXy/TjIpS56mxqZcU4aLuTtS i+OkV3oeeBwVtcupmyUONMQ= X-Google-Smtp-Source: AAOMgpc8VCMeULevOwhRuw2S05SejeSP3kwqmAfzu6osIa0Th39JJ8Neelc3h0pGWSqRqIGH0HTVJQ== X-Received: by 2002:ac8:29f6:: with SMTP id 51-v6mr1608348qtt.200.1531835428234; Tue, 17 Jul 2018 06:50:28 -0700 (PDT) Received: from localhost.localdomain (50-39-100-161.bvtn.or.frontiernet.net. [50.39.100.161]) by smtp.gmail.com with ESMTPSA id s83-v6sm640937qki.20.2018.07.17.06.50.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jul 2018 06:50:27 -0700 (PDT) From: Ram Pai To: shuahkh@osg.samsung.com, linux-kselftest@vger.kernel.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, dave.hansen@intel.com, mhocko@kernel.org, bauerman@linux.vnet.ibm.com, linuxram@us.ibm.com, fweimer@redhat.com, msuchanek@suse.de, aneesh.kumar@linux.vnet.ibm.com Subject: [PATCH v14 12/22] selftests/vm: pkey register should match shadow pkey Date: Tue, 17 Jul 2018 06:49:15 -0700 Message-Id: <1531835365-32387-13-git-send-email-linuxram@us.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> References: <1531835365-32387-1-git-send-email-linuxram@us.ibm.com> Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP expected_pkey_fault() is comparing the contents of pkey register with 0. This may not be true all the time. There could be bits set by default by the architecture which can never be changed. Hence compare the value against shadow pkey register, which is supposed to track the bits accurately all throughout cc: Dave Hansen cc: Florian Weimer Signed-off-by: Ram Pai --- tools/testing/selftests/vm/protection_keys.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vm/protection_keys.c b/tools/testing/selftests/vm/protection_keys.c index 2e448e0..f50cce8 100644 --- a/tools/testing/selftests/vm/protection_keys.c +++ b/tools/testing/selftests/vm/protection_keys.c @@ -913,10 +913,10 @@ void expected_pkey_fault(int pkey) pkey_assert(last_si_pkey == pkey); /* - * The signal handler shold have cleared out PKEY register to let the + * The signal handler should have cleared out pkey-register to let the * test program continue. We now have to restore it. */ - if (__read_pkey_reg() != 0) + if (__read_pkey_reg() != shadow_pkey_reg) pkey_assert(0); __write_pkey_reg(shadow_pkey_reg);