From patchwork Thu Jan 16 13:22:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 11336887 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 533DB6C1 for ; Thu, 16 Jan 2020 13:23:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30DBD2075B for ; Thu, 16 Jan 2020 13:23:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BGMS7Qso" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbgAPNXX (ORCPT ); Thu, 16 Jan 2020 08:23:23 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:36686 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726535AbgAPNWS (ORCPT ); Thu, 16 Jan 2020 08:22:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579180937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVICxkwYE819T09jumS9b6kqZZVW9alGabNhw2Byv4c=; b=BGMS7Qso2vvxNKbeNU5Isy3YUTyy3KLha9b4tf5sU9DyV0RHLPzE6DftI3CI3oV+53GY25 PsArIUENlTxqfd2HCRWFSENc9MP18rrb0HVWN0s6vdGQQQvxrhpMaVaj/1zqq9PSutAXGB p7gTpwWvD/H50XNi0dRjglYtwEYss/8= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-PPIpu0fsP2eyJyFDamHGKQ-1; Thu, 16 Jan 2020 08:22:15 -0500 X-MC-Unique: PPIpu0fsP2eyJyFDamHGKQ-1 Received: by mail-lj1-f200.google.com with SMTP id z17so5131943ljz.2 for ; Thu, 16 Jan 2020 05:22:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=oVICxkwYE819T09jumS9b6kqZZVW9alGabNhw2Byv4c=; b=hYcy0XE1VQI4XMKlSChFI2C5HGqSfZPxWKpIVkpYB3ubalvFnjSy6nH0nQMGcvWPE8 DpW/X8kI51UMWXkYa0FT7JJB/xbxmsTb27lFPl8VjUwjSLCewU2LRjOPc7jMr2hMxN+V 0E1SKOS6yD4ssOPKEZG0S5HIvw21T4mBqItwqesisUqWVdpAMW7/moebaqm7HI6Bg9/k VRlEBRjSp11YoR2gQKEXfqD2W7tdI3k7bnooo5+rxKYeQpAd06izD7t226jb/l1at0y4 0ml63mf5a3RHWHf1yTZ+61N3d8ymsPc92m1coA8aI7VXWlbL2JzzVXgZCN45XtnCtbts eiuA== X-Gm-Message-State: APjAAAVA2f9mo0reQ13B9mpPO/Mn5qQ0SeZx18eWR0zwPsdwKwcbSCmn ZsJQBqMwEtLaE38WI3d6YVTDhtXnkQW2CZUOTvwoP3EusR4gHYN5ns6jcFMKzw9pGVRx5diYKZE C+/p+xZkHvH4VPyX/fqvA+YIRT0fy X-Received: by 2002:a2e:b007:: with SMTP id y7mr2286042ljk.215.1579180934266; Thu, 16 Jan 2020 05:22:14 -0800 (PST) X-Google-Smtp-Source: APXvYqwQWrcaU+nW1F4XoH997rZHaa169MNBHkP1drBFjaeoj4ZaAxptcEhRwkbakFT89vmLfrEkOg== X-Received: by 2002:a2e:b007:: with SMTP id y7mr2286032ljk.215.1579180934124; Thu, 16 Jan 2020 05:22:14 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id f16sm10703433ljn.17.2020.01.16.05.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 05:22:13 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id D9E2F1804D7; Thu, 16 Jan 2020 14:22:12 +0100 (CET) Subject: [PATCH bpf-next v3 01/11] samples/bpf: Don't try to remove user's homedir on clean From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Alexei Starovoitov Cc: Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Doug Ledford , Jason Gunthorpe , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Shuah Khan , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, clang-built-linux@googlegroups.com Date: Thu, 16 Jan 2020 14:22:12 +0100 Message-ID: <157918093278.1357254.3453847369567754938.stgit@toke.dk> In-Reply-To: <157918093154.1357254.7616059374996162336.stgit@toke.dk> References: <157918093154.1357254.7616059374996162336.stgit@toke.dk> User-Agent: StGit/0.21 MIME-Version: 1.0 Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org From: Toke Høiland-Jørgensen The 'clean' rule in the samples/bpf Makefile tries to remove backup files (ending in ~). However, if no such files exist, it will instead try to remove the user's home directory. While the attempt is mostly harmless, it does lead to a somewhat scary warning like this: rm: cannot remove '~': Is a directory Fix this by using find instead of shell expansion to locate any actual backup files that need to be removed. Fixes: b62a796c109c ("samples/bpf: allow make to be run from samples/bpf/ directory") Acked-by: Jesper Dangaard Brouer Signed-off-by: Toke Høiland-Jørgensen --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index 5b89c0370f33..f86d713a17a5 100644 --- a/samples/bpf/Makefile +++ b/samples/bpf/Makefile @@ -254,7 +254,7 @@ all: clean: $(MAKE) -C ../../ M=$(CURDIR) clean - @rm -f *~ + @find $(CURDIR) -type f -name '*~' -delete $(LIBBPF): FORCE # Fix up variables inherited from Kbuild that tools/ build system won't like