diff mbox series

[net] selftests/net: add definition for SOL_DCCP to fix compilation errors for old libc

Message ID 1584557601-25202-1-git-send-email-alan.maguire@oracle.com
State Mainlined
Commit 83a9b6f639e9f6b632337f9776de17d51d969c77
Headers show
Series [net] selftests/net: add definition for SOL_DCCP to fix compilation errors for old libc | expand

Commit Message

Alan Maguire March 18, 2020, 6:53 p.m. UTC
Many systems build/test up-to-date kernels with older libcs, and
an older glibc (2.17) lacks the definition of SOL_DCCP in
/usr/include/bits/socket.h (it was added in the 4.6 timeframe).

Adding the definition to the test program avoids a compilation
failure that gets in the way of building tools/testing/selftests/net.
The test itself will work once the definition is added; either
skipping due to DCCP not being configured in the kernel under test
or passing, so there are no other more up-to-date glibc dependencies
here it seems beyond that missing definition.

Fixes: 11fb60d1089f ("selftests: net: reuseport_addr_any: add DCCP")
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
 tools/testing/selftests/net/reuseport_addr_any.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

David Miller March 22, 2020, 3:23 a.m. UTC | #1
From: Alan Maguire <alan.maguire@oracle.com>
Date: Wed, 18 Mar 2020 18:53:21 +0000

> Many systems build/test up-to-date kernels with older libcs, and
> an older glibc (2.17) lacks the definition of SOL_DCCP in
> /usr/include/bits/socket.h (it was added in the 4.6 timeframe).
> 
> Adding the definition to the test program avoids a compilation
> failure that gets in the way of building tools/testing/selftests/net.
> The test itself will work once the definition is added; either
> skipping due to DCCP not being configured in the kernel under test
> or passing, so there are no other more up-to-date glibc dependencies
> here it seems beyond that missing definition.
> 
> Fixes: 11fb60d1089f ("selftests: net: reuseport_addr_any: add DCCP")
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>

Applied.
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/reuseport_addr_any.c b/tools/testing/selftests/net/reuseport_addr_any.c
index c623393..b8475cb2 100644
--- a/tools/testing/selftests/net/reuseport_addr_any.c
+++ b/tools/testing/selftests/net/reuseport_addr_any.c
@@ -21,6 +21,10 @@ 
 #include <sys/socket.h>
 #include <unistd.h>
 
+#ifndef SOL_DCCP
+#define SOL_DCCP 269
+#endif
+
 static const char *IP4_ADDR = "127.0.0.1";
 static const char *IP6_ADDR = "::1";
 static const char *IP4_MAPPED6 = "::ffff:127.0.0.1";