| Message ID | 1615881577-3493-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ebda107e5f222a086c83ddf6d1ab1da97dd15810 |
| Headers | show |
| Series | selftests/bpf: fix warning comparing pointer to 0 | expand |
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 16 Mar 2021 15:59:37 +0800 you wrote: > Fix the following coccicheck warning: > > ./tools/testing/selftests/bpf/progs/fexit_test.c:77:15-16: WARNING > comparing pointer to 0. > > ./tools/testing/selftests/bpf/progs/fexit_test.c:68:12-13: WARNING > comparing pointer to 0. > > [...] Here is the summary with links: - selftests/bpf: fix warning comparing pointer to 0 https://git.kernel.org/bpf/bpf-next/c/ebda107e5f22 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
diff --git a/tools/testing/selftests/bpf/progs/fexit_test.c b/tools/testing/selftests/bpf/progs/fexit_test.c index 0952aff..8f1ccb7 100644 --- a/tools/testing/selftests/bpf/progs/fexit_test.c +++ b/tools/testing/selftests/bpf/progs/fexit_test.c @@ -65,7 +65,7 @@ struct bpf_fentry_test_t { SEC("fexit/bpf_fentry_test7") int BPF_PROG(test7, struct bpf_fentry_test_t *arg) { - if (arg == 0) + if (!arg) test7_result = 1; return 0; } @@ -74,7 +74,7 @@ int BPF_PROG(test7, struct bpf_fentry_test_t *arg) SEC("fexit/bpf_fentry_test8") int BPF_PROG(test8, struct bpf_fentry_test_t *arg) { - if (arg->a == 0) + if (!arg->a) test8_result = 1; return 0; }
Fix the following coccicheck warning: ./tools/testing/selftests/bpf/progs/fexit_test.c:77:15-16: WARNING comparing pointer to 0. ./tools/testing/selftests/bpf/progs/fexit_test.c:68:12-13: WARNING comparing pointer to 0. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- tools/testing/selftests/bpf/progs/fexit_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)