diff mbox series

[bpf-next,3/3] libbpf: propagate errors when retrieving enum value for typed data display

Message ID 1626730889-5658-4-git-send-email-alan.maguire@oracle.com (mailing list archive)
State New
Headers show
Series libbpf: btf typed data dumping fixes (__int128 usage, error propagation) | expand

Commit Message

Alan Maguire July 19, 2021, 9:41 p.m. UTC
When retrieving the enum value associated with typed data during
"is data zero?" checking in btf_dump_type_data_check_zero(), the
return value of btf_dump_get_enum_value() is not passed to the caller
if the function returns a non-zero (error) value.  Currently, 0
is returned if the function returns an error.  We should instead
propagate the error to the caller.

Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
 tools/lib/bpf/btf_dump.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/tools/lib/bpf/btf_dump.c b/tools/lib/bpf/btf_dump.c
index 4a25512..ddc900b 100644
--- a/tools/lib/bpf/btf_dump.c
+++ b/tools/lib/bpf/btf_dump.c
@@ -2145,8 +2145,9 @@  static int btf_dump_type_data_check_zero(struct btf_dump *d,
 		return -ENODATA;
-		if (btf_dump_get_enum_value(d, t, data, id, &value))
-			return 0;
+		err = btf_dump_get_enum_value(d, t, data, id, &value);
+		if (err)
+			return err;
 		if (value == 0)
 			return -ENODATA;
 		return 0;