| Message ID | 1648087725-29435-1-git-send-email-baihaowen@meizu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2609f635a20d3691e7b5725edc3bdadb7bedf8fb |
| Headers | show |
| Series | selftests/bpf: Fix warning comparing pointer to 0 | expand |
On Thu, Mar 24, 2022 at 10:08:45AM +0800, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. Which compiler version that warns ? I don't see it with the latest llvm-project from github. The patch lgtm. Acked-by: Martin KaFai Lau <kafai@fb.com>
hi, kafai ./scripts/coccicheck report this warning.
On 3/23/22 8:08 PM, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. > Patch looks good to me. Please include the error/warn message in the commit log. This gives reviewers information on how this problem is found. > Signed-off-by: Haowen Bai <baihaowen@meizu.com> > --- > tools/testing/selftests/bpf/progs/map_ptr_kern.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/bpf/progs/map_ptr_kern.c b/tools/testing/selftests/bpf/progs/map_ptr_kern.c > index b64df94..db388f5 100644 > --- a/tools/testing/selftests/bpf/progs/map_ptr_kern.c > +++ b/tools/testing/selftests/bpf/progs/map_ptr_kern.c > @@ -367,7 +367,7 @@ static inline int check_array_of_maps(void) > > VERIFY(check_default(&array_of_maps->map, map)); > inner_map = bpf_map_lookup_elem(array_of_maps, &key); > - VERIFY(inner_map != 0); > + VERIFY(inner_map != NULL); > VERIFY(inner_map->map.max_entries == INNER_MAX_ENTRIES); > > return 1; > @@ -394,7 +394,7 @@ static inline int check_hash_of_maps(void) > > VERIFY(check_default(&hash_of_maps->map, map)); > inner_map = bpf_map_lookup_elem(hash_of_maps, &key); > - VERIFY(inner_map != 0); > + VERIFY(inner_map != NULL); > VERIFY(inner_map->map.max_entries == INNER_MAX_ENTRIES); > > return 1; > With the change to commit log including the error/warn message and details on how the problems is found: Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
diff --git a/tools/testing/selftests/bpf/progs/map_ptr_kern.c b/tools/testing/selftests/bpf/progs/map_ptr_kern.c index b64df94..db388f5 100644 --- a/tools/testing/selftests/bpf/progs/map_ptr_kern.c +++ b/tools/testing/selftests/bpf/progs/map_ptr_kern.c @@ -367,7 +367,7 @@ static inline int check_array_of_maps(void) VERIFY(check_default(&array_of_maps->map, map)); inner_map = bpf_map_lookup_elem(array_of_maps, &key); - VERIFY(inner_map != 0); + VERIFY(inner_map != NULL); VERIFY(inner_map->map.max_entries == INNER_MAX_ENTRIES); return 1; @@ -394,7 +394,7 @@ static inline int check_hash_of_maps(void) VERIFY(check_default(&hash_of_maps->map, map)); inner_map = bpf_map_lookup_elem(hash_of_maps, &key); - VERIFY(inner_map != 0); + VERIFY(inner_map != NULL); VERIFY(inner_map->map.max_entries == INNER_MAX_ENTRIES); return 1;
Avoid pointer type value compared with 0 to make code clear. Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- tools/testing/selftests/bpf/progs/map_ptr_kern.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)