diff mbox series

[RESEND] .gitignore: Do not ignore .kunitconfig files

Message ID 168191307928.6696.11689169705819224951.stgit@91.116.238.104.host.secureserver.net (mailing list archive)
State Accepted
Commit 2bc42f482bedeafdbe70804fd82bdbf8f7e28b00
Headers show
Series [RESEND] .gitignore: Do not ignore .kunitconfig files | expand

Commit Message

Chuck Lever April 19, 2023, 2:05 p.m. UTC 
From: Chuck Lever <chuck.lever@oracle.com>

Circumvent the .gitignore wildcard to avoid warnings about ignored
.kunitconfig files. As far as I can tell, the warnings are harmless
and these files are not actually ignored.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304142337.jc4oUrov-lkp@intel.com/
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 .gitignore |    1 +
 1 file changed, 1 insertion(+)

Resending...  It was not clear to me if this file has a specific
maintainer. I chose to send it to the most recent committer.

Comments

David Gow April 20, 2023, 7:25 a.m. UTC | #1 
On Wed, 19 Apr 2023 at 22:05, Chuck Lever <cel@kernel.org> wrote:
>
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Circumvent the .gitignore wildcard to avoid warnings about ignored
> .kunitconfig files. As far as I can tell, the warnings are harmless
> and these files are not actually ignored.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304142337.jc4oUrov-lkp@intel.com/
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---

Thanks very much.

We have an equivalent patch already staged in the kselftest/kunit for 6.3:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit&id=cb8865fd865f5b2f656d0d91f3b0146ef1acb10d

Cheers,
-- David
Chuck Lever April 20, 2023, 1:34 p.m. UTC | #2 
> On Apr 20, 2023, at 3:25 AM, David Gow <davidgow@google.com> wrote:
> 
> On Wed, 19 Apr 2023 at 22:05, Chuck Lever <cel@kernel.org> wrote:
>> 
>> From: Chuck Lever <chuck.lever@oracle.com>
>> 
>> Circumvent the .gitignore wildcard to avoid warnings about ignored
>> .kunitconfig files. As far as I can tell, the warnings are harmless
>> and these files are not actually ignored.
>> 
>> Reported-by: kernel test robot <lkp@intel.com>
>> Link: https://lore.kernel.org/oe-kbuild-all/202304142337.jc4oUrov-lkp@intel.com/
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
> 
> Thanks very much.
> 
> We have an equivalent patch already staged in the kselftest/kunit for 6.3:
> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit&id=cb8865fd865f5b2f656d0d91f3b0146ef1acb10d

Most excellent.

Yesterday, Jakub accepted my patch in net-next as part of
a series that also adds additional Kunit tests. My patch
can be dropped or reverted to avoid a merge conflict.


--
Chuck Lever
diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index 70ec6037fa7a..51117ba29c88 100644
--- a/.gitignore
+++ b/.gitignore
@@ -105,6 +105,7 @@  modules.order
 !.gitignore
 !.mailmap
 !.rustfmt.toml
+!.kunitconfig
 
 #
 # Generated include files