| Message ID | 20190304183827.GA6809@jordon-HP-15-Notebook-PC (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | cde53520e2877f7f3a493e3a55d636baaf46903c |
| Headers | show |
| Series | selftest/rseq: Remove duplicate header | expand |
----- On Mar 4, 2019, at 1:38 PM, Souptick Joarder jrdr.linux@gmail.com wrote: > Remove duplicate header which is included twice > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > --- > tools/testing/selftests/rseq/rseq.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/testing/selftests/rseq/rseq.h > b/tools/testing/selftests/rseq/rseq.h > index c72eb70..6c1126e7 100644 > --- a/tools/testing/selftests/rseq/rseq.h > +++ b/tools/testing/selftests/rseq/rseq.h > @@ -16,7 +16,6 @@ > #include <errno.h> > #include <stdio.h> > #include <stdlib.h> > -#include <sched.h> > #include <linux/rseq.h> > > /* > -- > 1.9.1
On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote: > Remove duplicate header which is included twice > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> That SoB chain is invalid.
On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <peterz@infradead.org> wrote: > > On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote: > > Remove duplicate header which is included twice > > > > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com> > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > > That SoB chain is invalid. I didn't get why it is invalid ?
----- On Mar 4, 2019, at 1:53 PM, Souptick Joarder jrdr.linux@gmail.com wrote: > On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <peterz@infradead.org> wrote: >> >> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote: >> > Remove duplicate header which is included twice >> > >> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com> >> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> >> >> That SoB chain is invalid. > > I didn't get why it is invalid ? I think it's about having the author of the patch (From) as first Signed-off-by, and then apply following Signed-off-by by maintainers who pick up the patch. (That's what I am used to see) What is the intent behind the second Signed-off-by by Sabyasachi Gupta ? Thanks, Mathieu
On Tue, Mar 5, 2019 at 1:27 AM Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote: > > ----- On Mar 4, 2019, at 1:53 PM, Souptick Joarder jrdr.linux@gmail.com wrote: > > > On Tue, Mar 5, 2019 at 12:20 AM Peter Zijlstra <peterz@infradead.org> wrote: > >> > >> On Tue, Mar 05, 2019 at 12:08:27AM +0530, Souptick Joarder wrote: > >> > Remove duplicate header which is included twice > >> > > >> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com> > >> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > >> > >> That SoB chain is invalid. > > > > I didn't get why it is invalid ? > > I think it's about having the author of the patch (From) as first > Signed-off-by, and then apply following Signed-off-by by maintainers > who pick up the patch. (That's what I am used to see) > > What is the intent behind the second Signed-off-by by Sabyasachi Gupta ? Sabyasachi is the author and I am posting his patches as his email client has some issue. I think I need to add Sabyasachi's From: @ the beginning of change log. Andrew suggested the same in another thread. > > Thanks, > > Mathieu > > -- > Mathieu Desnoyers > EfficiOS Inc. > http://www.efficios.com
diff --git a/tools/testing/selftests/rseq/rseq.h b/tools/testing/selftests/rseq/rseq.h index c72eb70..6c1126e7 100644 --- a/tools/testing/selftests/rseq/rseq.h +++ b/tools/testing/selftests/rseq/rseq.h @@ -16,7 +16,6 @@ #include <errno.h> #include <stdio.h> #include <stdlib.h> -#include <sched.h> #include <linux/rseq.h> /*