From patchwork Wed Jun 5 21:37:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shuah Khan X-Patchwork-Id: 10977933 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 694C092A for ; Wed, 5 Jun 2019 21:37:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 58E8F28796 for ; Wed, 5 Jun 2019 21:37:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4C67E289D3; Wed, 5 Jun 2019 21:37:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EB31228796 for ; Wed, 5 Jun 2019 21:37:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726527AbfFEVhJ (ORCPT ); Wed, 5 Jun 2019 17:37:09 -0400 Received: from mail-it1-f193.google.com ([209.85.166.193]:54056 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbfFEVhJ (ORCPT ); Wed, 5 Jun 2019 17:37:09 -0400 Received: by mail-it1-f193.google.com with SMTP id m187so5905573ite.3 for ; Wed, 05 Jun 2019 14:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RddNyObAm0IDCsAeqeXV9IFkPclFRQuRiqHF+RZKGFg=; b=gU2c5w+dA8zAHUeXRZUJDm6mK83x2bcDiByc1SmfMfobUK8jfgOQgbFrERUtJ60LSb XFgrooOkCPIOYWl45gFK1RBnBmnziFRo6YZ3zmVo6EmDJbmz2oACKi9x/hH8iKGSV5Ki WZqVV/6A5zMARtc6KeQCp23iZl9C4dQnUVJQI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RddNyObAm0IDCsAeqeXV9IFkPclFRQuRiqHF+RZKGFg=; b=KLDyebCMzEM1ud0it58l4N0GhVFIK6T5wiiir4qLpTpSu+lE3gB3WPO3xIt77bB0bg wRKTVKAJ1min8tuHpxZ0J9FDFnU+aDPcTbBrHDCp6csAt1YBTJaXOVnBMKbh+CVVd+Wh qhrVr9WGdm0Q61/QJ7OtWYK/OyYHSNskeIpthuyMfWYzCg7nHyzTjvu0bCblkTJLTPA9 nvWV6K74s12LrWP/6mpJBwWxcvo7m9l9Sq+plhQ7O+JBt+Uj25lQ3PZ6sx7fBmPIL6fH nqYLrySteBdRTL+pTiUHBJCDO29XR4x3IJDa555gzeHZ91vPLSvPAVByCl4zY9GDJafP FYSA== X-Gm-Message-State: APjAAAUZ4TnrpTLcaV0cPK3j99IlMprJ/GCsvV319BYgBY0k8MJ/RZOJ V6tO8J6pmWE0HxXjc70d3pbeew== X-Google-Smtp-Source: APXvYqxShW/LVwJ43kgJhL1H+U4Cw5dPlZFogSQVfZKY2qC/2YAbcXab5oWgSqEOiLg4I3ZHuVy9SQ== X-Received: by 2002:a02:878a:: with SMTP id t10mr27772528jai.112.1559770628440; Wed, 05 Jun 2019 14:37:08 -0700 (PDT) Received: from shuah-t480s.internal (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id z71sm29753itc.6.2019.06.05.14.37.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 14:37:07 -0700 (PDT) From: Shuah Khan To: shuah@kernel.org Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests: vm: Fix test build failure when built by itself Date: Wed, 5 Jun 2019 15:37:04 -0600 Message-Id: <20190605213704.22902-1-skhan@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP vm test build fails when test is built by itself using make -C tools/testing/selftests/vm or cd tools/testing/selftests/vm; make When the test is built invoking its Makefile directly, it defines OUTPUT which conflicts with lib.mk's logic to install headers. make --no-builtin-rules INSTALL_HDR_PATH=$OUTPUT/usr \ ARCH=x86 -C ../../../.. headers_install make[1]: Entering directory '/mnt/data/lkml/linux_5.2' REMOVE shmparam.h rm: cannot remove '/usr/include/asm-generic/shmparam.h': Permission denied scripts/Makefile.headersinst:96: recipe for target '/usr/include/asm-generic/.install' failed make[3]: *** [/usr/include/asm-generic/.install] Error 1 scripts/Makefile.headersinst:32: recipe for target 'asm-generic' failed make[2]: *** [asm-generic] Error 2 Makefile:1199: recipe for target 'headers_install' failed make[1]: *** [headers_install] Error 2 make[1]: Leaving directory '/mnt/data/lkml/linux_5.2' ../lib.mk:52: recipe for target 'khdr' failed make: *** [khdr] Error 2 Fixes: 8ce72dc32578 ("selftests: fix headers_install circular dependency") Signed-off-by: Shuah Khan --- tools/testing/selftests/vm/Makefile | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile index 05306c58ff9f..9534dc2bc929 100644 --- a/tools/testing/selftests/vm/Makefile +++ b/tools/testing/selftests/vm/Makefile @@ -1,10 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 # Makefile for vm selftests -ifndef OUTPUT - OUTPUT := $(shell pwd) -endif - CFLAGS = -Wall -I ../../../../usr/include $(EXTRA_CFLAGS) LDLIBS = -lrt TEST_GEN_FILES = compaction_test