| Message ID | 20191105094029.21213-1-ice_yangxiao@163.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmabuf-heaps/dmabuf-heap.c: Initialize features variable to avoid compiler warning | expand |
On 11/5/19 2:40 AM, Xiao Yang wrote: > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Xiao Yang <ice_yangxiao@163.com> Missing commit log. Please add one to show the compiler warn you are fixing. > --- > tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > index ec47901ef2e2..5e3eeec299b2 100644 > --- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > +++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c > @@ -154,7 +154,7 @@ static int do_test(char *heap_name) > int heap_fd = -1, dmabuf_fd = -1, importer_fd = -1; > uint32_t handle = 0; > void *p = NULL; > - unsigned long long features; > + unsigned long long features = 0; > int ret; > > printf("Testing heap: %s\n", heap_name); > thanks, -- Shuah
On Thu, Nov 7, 2019 at 12:30 PM shuah <shuah@kernel.org> wrote: > On 11/5/19 2:40 AM, Xiao Yang wrote: > > Reported-by: kernel test robot <lkp@intel.com> > > Signed-off-by: Xiao Yang <ice_yangxiao@163.com> > > Missing commit log. Please add one to show the compiler warn you are > fixing. Shuah's feedback is good advice for future patches, but I wanted to clarify that I've dropped the affected code, so there's no reason to respin this patch. thanks -john
diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c index ec47901ef2e2..5e3eeec299b2 100644 --- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c +++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c @@ -154,7 +154,7 @@ static int do_test(char *heap_name) int heap_fd = -1, dmabuf_fd = -1, importer_fd = -1; uint32_t handle = 0; void *p = NULL; - unsigned long long features; + unsigned long long features = 0; int ret; printf("Testing heap: %s\n", heap_name);
Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Xiao Yang <ice_yangxiao@163.com> --- tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)