| Message ID | 20191107125224.29616-1-anders.roxell@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] selftests: bpf: test_lwt_ip_encap: add missing object file to TEST_FILES | expand |
On Thu, Nov 7, 2019 at 4:53 AM Anders Roxell <anders.roxell@linaro.org> wrote: > > When installing kselftests to its own directory and running the > test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be > find. > > $ ./test_lwt_ip_encap.sh > starting egress IPv4 encap test > Error opening object test_lwt_ip_encap.o: No such file or directory > Object hashing failed! > Cannot initialize ELF context! > Failed to parse eBPF program: Invalid argument > > Rework to add test_lwt_ip_encap.o to TEST_FILES so the object file gets > installed when installing kselftest. > > Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule") > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Please highlight that this set is on top of bpf-next tree with "[PATCH bpf-next 1/2]". Otherwise, looks good to me. Acked-by: Song Liu <songliubraving@fb.com>
On Thu, 7 Nov 2019 at 18:55, Song Liu <liu.song.a23@gmail.com> wrote: > > On Thu, Nov 7, 2019 at 4:53 AM Anders Roxell <anders.roxell@linaro.org> wrote: > > > > When installing kselftests to its own directory and running the > > test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be > > find. > > > > $ ./test_lwt_ip_encap.sh > > starting egress IPv4 encap test > > Error opening object test_lwt_ip_encap.o: No such file or directory > > Object hashing failed! > > Cannot initialize ELF context! > > Failed to parse eBPF program: Invalid argument > > > > Rework to add test_lwt_ip_encap.o to TEST_FILES so the object file gets > > installed when installing kselftest. > > > > Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule") > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > Please highlight that this set is on top of bpf-next tree with > "[PATCH bpf-next 1/2]". Oh right, I'll send out that shortly Cheers, Anders > > Otherwise, looks good to me. > > Acked-by: Song Liu <songliubraving@fb.com>
diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile index b334a6db15c1..cc09b5df9403 100644 --- a/tools/testing/selftests/bpf/Makefile +++ b/tools/testing/selftests/bpf/Makefile @@ -38,7 +38,7 @@ TEST_GEN_PROGS += test_progs-bpf_gcc endif TEST_GEN_FILES = -TEST_FILES = +TEST_FILES = test_lwt_ip_encap.o # Order correspond to 'make run_tests' order TEST_PROGS := test_kmod.sh \
When installing kselftests to its own directory and running the test_lwt_ip_encap.sh it will complain that test_lwt_ip_encap.o can't be find. $ ./test_lwt_ip_encap.sh starting egress IPv4 encap test Error opening object test_lwt_ip_encap.o: No such file or directory Object hashing failed! Cannot initialize ELF context! Failed to parse eBPF program: Invalid argument Rework to add test_lwt_ip_encap.o to TEST_FILES so the object file gets installed when installing kselftest. Fixes: 74b5a5968fe8 ("selftests/bpf: Replace test_progs and test_maps w/ general rule") Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- tools/testing/selftests/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)