diff mbox series

[net] selftests:mptcp:pm: rm the right tmp file

Message ID 20200515155442.1910397-1-matthieu.baerts@tessares.net (mailing list archive)
State Mainlined
Commit 9a2dbb59ebd17a91f99a20b0286dfb6445981ecf
Headers show
Series [net] selftests:mptcp:pm: rm the right tmp file | expand

Commit Message

Matthieu Baerts May 15, 2020, 3:54 p.m. UTC 
"$err" is a variable pointing to a temp file. "$out" is not: only used
as a local variable in "check()" and representing the output of a
command line.

Fixes: eedbc685321b (selftests: add PM netlink functional tests)
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
 tools/testing/selftests/net/mptcp/pm_netlink.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller May 15, 2020, 5:34 p.m. UTC | #1 
From: Matthieu Baerts <matthieu.baerts@tessares.net>
Date: Fri, 15 May 2020 17:54:41 +0200

> "$err" is a variable pointing to a temp file. "$out" is not: only used
> as a local variable in "check()" and representing the output of a
> command line.
> 
> Fixes: eedbc685321b (selftests: add PM netlink functional tests)
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>

Applied, thanks.
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/mptcp/pm_netlink.sh b/tools/testing/selftests/net/mptcp/pm_netlink.sh
index 9172746b6cf0..15f4f46ca3a9 100755
--- a/tools/testing/selftests/net/mptcp/pm_netlink.sh
+++ b/tools/testing/selftests/net/mptcp/pm_netlink.sh
@@ -30,7 +30,7 @@  ret=0
 
 cleanup()
 {
-	rm -f $out
+	rm -f $err
 	ip netns del $ns1
 }