| Message ID | 20200817150946.21477-1-dvlasenk@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | selftests: use "$(MAKE)" instead of "make" for headers_install | expand |
On 8/17/20 9:09 AM, Denys Vlasenko wrote: > If top make invocation uses -j4 or larger, this patch reduces > "make headers_install" subtask run time from 30 to 7 seconds. > > CC: Shuah Khan <shuah@kernel.org> > CC: Shuah Khan <skhan@linuxfoundation.org> > CC: linux-kselftest@vger.kernel.org > CC: linux-kernel@vger.kernel.org > Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> > --- > tools/testing/selftests/lib.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk > index 7a17ea815736..51124b962d56 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -47,9 +47,9 @@ ARCH ?= $(SUBARCH) > khdr: > ifndef KSFT_KHDR_INSTALL_DONE > ifeq (1,$(DEFAULT_INSTALL_HDR_PATH)) > - make --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install > + $(MAKE) --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install > else > - make --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \ > + $(MAKE) --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \ > ARCH=$(ARCH) -C $(top_srcdir) headers_install > endif > endif > Thanks for the patch. Applied to linux-kselftest next for 5.10 thanks, -- Shuah
diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 7a17ea815736..51124b962d56 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -47,9 +47,9 @@ ARCH ?= $(SUBARCH) khdr: ifndef KSFT_KHDR_INSTALL_DONE ifeq (1,$(DEFAULT_INSTALL_HDR_PATH)) - make --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install + $(MAKE) --no-builtin-rules ARCH=$(ARCH) -C $(top_srcdir) headers_install else - make --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \ + $(MAKE) --no-builtin-rules INSTALL_HDR_PATH=$$OUTPUT/usr \ ARCH=$(ARCH) -C $(top_srcdir) headers_install endif endif
If top make invocation uses -j4 or larger, this patch reduces "make headers_install" subtask run time from 30 to 7 seconds. CC: Shuah Khan <shuah@kernel.org> CC: Shuah Khan <skhan@linuxfoundation.org> CC: linux-kselftest@vger.kernel.org CC: linux-kernel@vger.kernel.org Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com> --- tools/testing/selftests/lib.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)