| Message ID | 20201015120851.229242-1-vitor@massaru.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 294a7f1613ee49a608361bd319519561c0ca7e72 |
| Headers | show |
| Series | lib: kunit: Fix compilation test when using TEST_BIT_FIELD_COMPILE | expand |
On Thu, Oct 15, 2020 at 5:08 AM Vitor Massaru Iha <vitor@massaru.org> wrote: > > A build condition was missing around a compilation test, this compilation > test comes from the original test_bitfield code. > > And removed unnecessary code for this test. > > Fixes: d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit") > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org> > Link: https://lore.kernel.org/linux-next/20201015163056.56fcc835@canb.auug.org.au/ Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Thanks for taking care of this so quickly!
On 10/16/20 12:42 PM, Brendan Higgins wrote: > On Thu, Oct 15, 2020 at 5:08 AM Vitor Massaru Iha <vitor@massaru.org> wrote: >> >> A build condition was missing around a compilation test, this compilation >> test comes from the original test_bitfield code. >> >> And removed unnecessary code for this test. >> >> Fixes: d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit") >> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org> >> Link: https://lore.kernel.org/linux-next/20201015163056.56fcc835@canb.auug.org.au/ > > Reviewed-by: Brendan Higgins <brendanhiggins@google.com> > > Thanks for taking care of this so quickly! > Thank you both. Applied to linux-kselftest kunit branch I will send the pull request with this in a day or two. Added Reported-by for Stephen. Thanks for finding the problem. thanks, -- Shuah
diff --git a/lib/bitfield_kunit.c b/lib/bitfield_kunit.c index d63a2be5aff8..1473d8b4bf0f 100644 --- a/lib/bitfield_kunit.c +++ b/lib/bitfield_kunit.c @@ -125,7 +125,7 @@ static void __init test_bitfields_variables(struct kunit *context) CHECK(u64, 0x0000001f8000000ull); } - +#ifdef TEST_BITFIELD_COMPILE static void __init test_bitfields_compile(struct kunit *context) { /* these should fail compilation */ @@ -135,13 +135,11 @@ static void __init test_bitfields_compile(struct kunit *context) /* this should at least give a warning */ u16_encode_bits(0, 0x60000); } +#endif static struct kunit_case __refdata bitfields_test_cases[] = { KUNIT_CASE(test_bitfields_constants), KUNIT_CASE(test_bitfields_variables), -#ifdef TEST_BITFIELD_COMPILE - KUNIT_CASE(test_bitfields_compile), -#endif {} };
A build condition was missing around a compilation test, this compilation test comes from the original test_bitfield code. And removed unnecessary code for this test. Fixes: d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit") Signed-off-by: Vitor Massaru Iha <vitor@massaru.org> Link: https://lore.kernel.org/linux-next/20201015163056.56fcc835@canb.auug.org.au/ --- lib/bitfield_kunit.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) base-commit: d2585f5164c298aaaed14c2c8d313cbe7bd5b253