diff mbox series

kunit: Fix kunit.py --raw_output option

Message ID 20201022030455.1871987-1-davidgow@google.com
State Accepted
Delegated to: Shuah Khan
Headers show
Series kunit: Fix kunit.py --raw_output option | expand

Commit Message

David Gow Oct. 22, 2020, 3:04 a.m. UTC
Due to the raw_output() function on kunit_parser.py actually being a
generator, it only runs if something reads the lines it returns. Since
we no-longer do that (parsing doesn't actually happen if raw_output is
enabled), it was not printing anything.

Fixes:	45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")
Signed-off-by: David Gow <davidgow@google.com>
---
 tools/testing/kunit/kunit_parser.py | 1 -
 1 file changed, 1 deletion(-)

Comments

Brendan Higgins Oct. 22, 2020, 4:11 a.m. UTC | #1
On Wed, Oct 21, 2020 at 8:05 PM David Gow <davidgow@google.com> wrote:
>
> Due to the raw_output() function on kunit_parser.py actually being a
> generator, it only runs if something reads the lines it returns. Since
> we no-longer do that (parsing doesn't actually happen if raw_output is
> enabled), it was not printing anything.
>
> Fixes:  45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")
> Signed-off-by: David Gow <davidgow@google.com>

Thanks for fixing this!

Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com>
Shuah Khan Oct. 26, 2020, 7:31 p.m. UTC | #2
On 10/21/20 10:11 PM, Brendan Higgins wrote:
> On Wed, Oct 21, 2020 at 8:05 PM David Gow <davidgow@google.com> wrote:
>>
>> Due to the raw_output() function on kunit_parser.py actually being a
>> generator, it only runs if something reads the lines it returns. Since
>> we no-longer do that (parsing doesn't actually happen if raw_output is
>> enabled), it was not printing anything.
>>
>> Fixes:  45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")

You need just the SHA1 45ba7a893ad8

Fixed this up and applied to linux-kselftest kunit-fixes branch


>> Signed-off-by: David Gow <davidgow@google.com>
> 
> Thanks for fixing this!
> 
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> Tested-by: Brendan Higgins <brendanhiggins@google.com>
> 

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/tools/testing/kunit/kunit_parser.py b/tools/testing/kunit/kunit_parser.py
index 8019e3dd4c32..744ee9cb0073 100644
--- a/tools/testing/kunit/kunit_parser.py
+++ b/tools/testing/kunit/kunit_parser.py
@@ -66,7 +66,6 @@  def isolate_kunit_output(kernel_output):
 def raw_output(kernel_output):
 	for line in kernel_output:
 		print(line)
-		yield line
 
 DIVIDER = '=' * 60