| Message ID | 20201112180732.75589-2-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/6] lib/list_kunit: Follow new file name convention for KUnit tests | expand |
Hello, On Thu, 2020-11-12 at 20:07 +0200, Andy Shevchenko wrote: > Follow new file name convention for the KUnit tests. > Since we have lib/*test*.c in a few variations, > use 'kunit' suffix to distinguish usual test cases > with KUnit-based ones. > > Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reviewed-by: David Gow <davidgow@google.com> > Acked-by: Mark Brown <broonie@kernel.org> > --- > v4: added tag (Mark) > > MAINTAINERS | 3 +-- > lib/Makefile | 2 +- > lib/{test_linear_ranges.c => linear_ranges_kunit.c} | 0 > 3 files changed, 2 insertions(+), 3 deletions(-) > rename lib/{test_linear_ranges.c => linear_ranges_kunit.c} (100%) Sorry for late reaction. I need to adjust my mail filters. The KUnit mails evaded my inbox even when I was in CC. I have own folder for KUnit - which I do not look daily. (And no Brendan, the folder is not called "trash", its's "kunit" and I do occasionally skim through the mails there). I see this was already applied so it is late - but I wanted to say thank you for taking care of this Andy. It looks good to me. --Matti -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. "non cogito me" dixit Rene Descarte, deinde evanescavit (Thanks for the translation Simon)
On Fri, Nov 13, 2020 at 06:22:08AM +0000, Vaittinen, Matti wrote: > On Thu, 2020-11-12 at 20:07 +0200, Andy Shevchenko wrote: > > Follow new file name convention for the KUnit tests. > > Since we have lib/*test*.c in a few variations, > > use 'kunit' suffix to distinguish usual test cases > > with KUnit-based ones. > Sorry for late reaction. I need to adjust my mail filters. The KUnit > mails evaded my inbox even when I was in CC. I have own folder for > KUnit - which I do not look daily. (And no Brendan, the folder is not > called "trash", its's "kunit" and I do occasionally skim through the > mails there). > > I see this was already applied so it is late - but I wanted to say > thank you for taking care of this Andy. It looks good to me. You are welcome! And thanks for review.
diff --git a/MAINTAINERS b/MAINTAINERS index 5901b817d0bc..9a314e618705 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10103,8 +10103,7 @@ F: include/uapi/linux/lightnvm.h LINEAR RANGES HELPERS M: Mark Brown <broonie@kernel.org> R: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> -F: lib/linear_ranges.c -F: lib/test_linear_ranges.c +F: lib/linear_ranges*.c F: include/linux/linear_range.h LINUX FOR POWER MACINTOSH diff --git a/lib/Makefile b/lib/Makefile index 9d78ef73d6ed..ef25cd94f34d 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -349,6 +349,6 @@ obj-$(CONFIG_PLDMFW) += pldmfw/ # KUnit tests obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o +obj-$(CONFIG_LINEAR_RANGES_TEST) += linear_ranges_kunit.o obj-$(CONFIG_LIST_KUNIT_TEST) += list_kunit.o -obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o obj-$(CONFIG_BITS_TEST) += test_bits.o diff --git a/lib/test_linear_ranges.c b/lib/linear_ranges_kunit.c similarity index 100% rename from lib/test_linear_ranges.c rename to lib/linear_ranges_kunit.c