diff mbox series

[02/11] kselftest/arm64: mte: Fix pthread linking

Message ID 20210319165334.29213-3-andre.przywara@arm.com (mailing list archive)
State Accepted
Commit e5decefd884da1c2c6ea18fca17b80b189afcc43
Headers show
Series kselftest/arm64: mte: Fix feature detection and compilation | expand

Commit Message

Andre Przywara March 19, 2021, 4:53 p.m. UTC
The GCC manual suggests to use -pthread, when linking with the PThread
library, also to add this switch to both the compilation and linking

Do as the manual says, to fix compilation with Ubuntu's 20.04 toolchain,
which was getting -lpthread too early on the command line:
/usr/bin/ld: /tmp/cc5zbo2A.o: in function `execute_test':
	undefined reference to `pthread_create'
/usr/bin/ld: tools/testing/selftests/arm64/mte/check_gcr_el1_cswitch.c:90:
	undefined reference to `pthread_join'

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
 tools/testing/selftests/arm64/mte/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series


diff --git a/tools/testing/selftests/arm64/mte/Makefile b/tools/testing/selftests/arm64/mte/Makefile
index df15d44aeb8d..90aadd86fa0d 100644
--- a/tools/testing/selftests/arm64/mte/Makefile
+++ b/tools/testing/selftests/arm64/mte/Makefile
@@ -1,7 +1,8 @@ 
 # SPDX-License-Identifier: GPL-2.0
 # Copyright (C) 2020 ARM Limited
-CFLAGS += -std=gnu99 -I. -lpthread
+CFLAGS += -std=gnu99 -I. -pthread
+LDFLAGS += -pthread
 SRCS := $(filter-out mte_common_util.c,$(wildcard *.c))
 PROGS := $(patsubst %.c,%,$(SRCS))