| Message ID | 20210802071449.588393-1-zhang.yunkai@zte.com.cn (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [linux-next] tools: remove unneeded semicolon | expand |
On 8/2/21 1:14 AM, cgel.zte@gmail.com wrote: > From: Zhang Yunkai <zhang.yunkai@zte.com.cn> > > Fix the following coccicheck REVIEW: > ./tools/testing/selftests/timers/inconsistency-check.c:75:2-3 REVIEW > Unneeded semicolon > ./tools/testing/selftests/timers/set-timer-lat.c:83:2-3 REVIEW Unneeded > semicolon > ./tools/virtio/virtio-trace/trace-agent-ctl.c:78:2-3 REVIEW Unneeded > semicolon > ./tools/testing/selftests/timers/nanosleep.c:75:2-3 REVIEW Unneeded > semicolon > ./tools/testing/selftests/timers/nsleep-lat.c:75:2-3 REVIEW Unneeded > semicolon > ./tools/testing/selftests/timers/alarmtimer-suspend.c:82:2-3 REVIEW > Unneeded semicolon > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn> > --- > tools/testing/selftests/timers/alarmtimer-suspend.c | 2 +- > tools/testing/selftests/timers/inconsistency-check.c | 2 +- > tools/testing/selftests/timers/nanosleep.c | 2 +- > tools/testing/selftests/timers/nsleep-lat.c | 2 +- > tools/testing/selftests/timers/set-timer-lat.c | 2 +- > tools/virtio/virtio-trace/trace-agent-ctl.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/timers/alarmtimer-suspend.c b/tools/testing/selftests/timers/alarmtimer-suspend.c > index 4da09dbf83ba..54da4b088f4c 100644 > --- a/tools/testing/selftests/timers/alarmtimer-suspend.c > +++ b/tools/testing/selftests/timers/alarmtimer-suspend.c > @@ -79,7 +79,7 @@ char *clockstring(int clockid) > return "CLOCK_BOOTTIME_ALARM"; > case CLOCK_TAI: > return "CLOCK_TAI"; > - }; > + } > return "UNKNOWN_CLOCKID"; > } > > diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c > index 022d3ffe3fbf..e6756d9c60a7 100644 > --- a/tools/testing/selftests/timers/inconsistency-check.c > +++ b/tools/testing/selftests/timers/inconsistency-check.c > @@ -72,7 +72,7 @@ char *clockstring(int clockid) > return "CLOCK_BOOTTIME_ALARM"; > case CLOCK_TAI: > return "CLOCK_TAI"; > - }; > + } > return "UNKNOWN_CLOCKID"; > } > > diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c > index 71b5441c2fd9..433a09676aeb 100644 > --- a/tools/testing/selftests/timers/nanosleep.c > +++ b/tools/testing/selftests/timers/nanosleep.c > @@ -72,7 +72,7 @@ char *clockstring(int clockid) > return "CLOCK_BOOTTIME_ALARM"; > case CLOCK_TAI: > return "CLOCK_TAI"; > - }; > + } > return "UNKNOWN_CLOCKID"; > } > > diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c > index eb3e79ed7b4a..a7ca9825e106 100644 > --- a/tools/testing/selftests/timers/nsleep-lat.c > +++ b/tools/testing/selftests/timers/nsleep-lat.c > @@ -72,7 +72,7 @@ char *clockstring(int clockid) > return "CLOCK_BOOTTIME_ALARM"; > case CLOCK_TAI: > return "CLOCK_TAI"; > - }; > + } > return "UNKNOWN_CLOCKID"; > } > > diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c > index 50da45437daa..d60bbcad487f 100644 > --- a/tools/testing/selftests/timers/set-timer-lat.c > +++ b/tools/testing/selftests/timers/set-timer-lat.c > @@ -80,7 +80,7 @@ char *clockstring(int clockid) > return "CLOCK_BOOTTIME_ALARM"; > case CLOCK_TAI: > return "CLOCK_TAI"; > - }; > + } > return "UNKNOWN_CLOCKID"; > } > > diff --git a/tools/virtio/virtio-trace/trace-agent-ctl.c b/tools/virtio/virtio-trace/trace-agent-ctl.c > index 73d253d4b559..39860be6e2d8 100644 > --- a/tools/virtio/virtio-trace/trace-agent-ctl.c > +++ b/tools/virtio/virtio-trace/trace-agent-ctl.c > @@ -75,7 +75,7 @@ static int wait_order(int ctl_fd) > > if (ret) > break; > - }; > + } > > return ret; > > We can't accept this patch. The from and Signed-off-by don't match. thanks, -- Shuah
diff --git a/tools/testing/selftests/timers/alarmtimer-suspend.c b/tools/testing/selftests/timers/alarmtimer-suspend.c index 4da09dbf83ba..54da4b088f4c 100644 --- a/tools/testing/selftests/timers/alarmtimer-suspend.c +++ b/tools/testing/selftests/timers/alarmtimer-suspend.c @@ -79,7 +79,7 @@ char *clockstring(int clockid) return "CLOCK_BOOTTIME_ALARM"; case CLOCK_TAI: return "CLOCK_TAI"; - }; + } return "UNKNOWN_CLOCKID"; } diff --git a/tools/testing/selftests/timers/inconsistency-check.c b/tools/testing/selftests/timers/inconsistency-check.c index 022d3ffe3fbf..e6756d9c60a7 100644 --- a/tools/testing/selftests/timers/inconsistency-check.c +++ b/tools/testing/selftests/timers/inconsistency-check.c @@ -72,7 +72,7 @@ char *clockstring(int clockid) return "CLOCK_BOOTTIME_ALARM"; case CLOCK_TAI: return "CLOCK_TAI"; - }; + } return "UNKNOWN_CLOCKID"; } diff --git a/tools/testing/selftests/timers/nanosleep.c b/tools/testing/selftests/timers/nanosleep.c index 71b5441c2fd9..433a09676aeb 100644 --- a/tools/testing/selftests/timers/nanosleep.c +++ b/tools/testing/selftests/timers/nanosleep.c @@ -72,7 +72,7 @@ char *clockstring(int clockid) return "CLOCK_BOOTTIME_ALARM"; case CLOCK_TAI: return "CLOCK_TAI"; - }; + } return "UNKNOWN_CLOCKID"; } diff --git a/tools/testing/selftests/timers/nsleep-lat.c b/tools/testing/selftests/timers/nsleep-lat.c index eb3e79ed7b4a..a7ca9825e106 100644 --- a/tools/testing/selftests/timers/nsleep-lat.c +++ b/tools/testing/selftests/timers/nsleep-lat.c @@ -72,7 +72,7 @@ char *clockstring(int clockid) return "CLOCK_BOOTTIME_ALARM"; case CLOCK_TAI: return "CLOCK_TAI"; - }; + } return "UNKNOWN_CLOCKID"; } diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c index 50da45437daa..d60bbcad487f 100644 --- a/tools/testing/selftests/timers/set-timer-lat.c +++ b/tools/testing/selftests/timers/set-timer-lat.c @@ -80,7 +80,7 @@ char *clockstring(int clockid) return "CLOCK_BOOTTIME_ALARM"; case CLOCK_TAI: return "CLOCK_TAI"; - }; + } return "UNKNOWN_CLOCKID"; } diff --git a/tools/virtio/virtio-trace/trace-agent-ctl.c b/tools/virtio/virtio-trace/trace-agent-ctl.c index 73d253d4b559..39860be6e2d8 100644 --- a/tools/virtio/virtio-trace/trace-agent-ctl.c +++ b/tools/virtio/virtio-trace/trace-agent-ctl.c @@ -75,7 +75,7 @@ static int wait_order(int ctl_fd) if (ret) break; - }; + } return ret;