| Message ID | 20211110103552.60181-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 60c7801b121aa0e90d8aae7245859aec0ce2306f |
| Delegated to: | Brendan Higgins |
| Headers | show |
| Series | [v1,1/1] kunit: Replace kernel.h with the necessary inclusions | expand |
On Wed, Nov 10, 2021 at 12:35:52PM +0200, Andy Shevchenko wrote: > When kernel.h is used in the headers it adds a lot into dependency hell, > especially when there are circular dependencies are involved. > > Replace kernel.h inclusion with the list of what is really being used. Can it be applied now?
On Mon, Nov 15, 2021 at 01:34:08PM +0200, Andy Shevchenko wrote: > On Wed, Nov 10, 2021 at 12:35:52PM +0200, Andy Shevchenko wrote: > > When kernel.h is used in the headers it adds a lot into dependency hell, > > especially when there are circular dependencies are involved. > > > > Replace kernel.h inclusion with the list of what is really being used. > > Can it be applied now? Any news so far? Should I do anything about this patch?
On Wed, Nov 10, 2021 at 12:35:52PM +0200, Andy Shevchenko wrote: > When kernel.h is used in the headers it adds a lot into dependency hell, > especially when there are circular dependencies are involved. > > Replace kernel.h inclusion with the list of what is really being used. Folks, this patch is dated month ago and nothing in return. Does the Kunit subsystem abandoned / orphaned? Should I send and update to MAINTAINERS? Should I escalate this?
diff --git a/include/kunit/assert.h b/include/kunit/assert.h index ad889b539ab3..ccbc36c0b02f 100644 --- a/include/kunit/assert.h +++ b/include/kunit/assert.h @@ -10,7 +10,7 @@ #define _KUNIT_ASSERT_H #include <linux/err.h> -#include <linux/kernel.h> +#include <linux/printk.h> struct kunit; struct string_stream;
When kernel.h is used in the headers it adds a lot into dependency hell, especially when there are circular dependencies are involved. Replace kernel.h inclusion with the list of what is really being used. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/kunit/assert.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)