diff mbox series

selftests/bpf: use swap() to make code cleaner

Message ID 20211112032704.4658-1-hanyihao@vivo.com (mailing list archive)
State New
Headers show
Series selftests/bpf: use swap() to make code cleaner | expand

Commit Message

Yihao Han Nov. 12, 2021, 3:27 a.m. UTC 
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 tools/testing/selftests/bpf/progs/test_xdp_noinline.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Alexei Starovoitov Nov. 12, 2021, 5:06 a.m. UTC | #1 
On Thu, Nov 11, 2021 at 7:27 PM Yihao Han <hanyihao@vivo.com> wrote:
>
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>

The point of the selftest is to open code it.
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/progs/test_xdp_noinline.c b/tools/testing/selftests/bpf/progs/test_xdp_noinline.c
index 596c4e71bf3a..6d9972168a7c 100644
--- a/tools/testing/selftests/bpf/progs/test_xdp_noinline.c
+++ b/tools/testing/selftests/bpf/progs/test_xdp_noinline.c
@@ -428,7 +428,6 @@  int send_icmp_reply(void *data, void *data_end)
 {
 	struct icmphdr *icmp_hdr;
 	__u16 *next_iph_u16;
-	__u32 tmp_addr = 0;
 	struct iphdr *iph;
 	__u32 csum1 = 0;
 	__u32 csum = 0;
@@ -444,9 +443,7 @@  int send_icmp_reply(void *data, void *data_end)
 	icmp_hdr->type = 0;
 	icmp_hdr->checksum += 0x0007;
 	iph->ttl = 4;
-	tmp_addr = iph->daddr;
-	iph->daddr = iph->saddr;
-	iph->saddr = tmp_addr;
+	swap(iph->daddr, iph->saddr);
 	iph->check = 0;
 	next_iph_u16 = (__u16 *) iph;
 #pragma clang loop unroll(full)