| Message ID | 20211129075451.418122-4-anup.patel@wdc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | KVM RISC-V 64-bit selftests support | expand |
On Mon, Nov 29, 2021 at 12:10 AM Anup Patel <anup.patel@wdc.com> wrote: > > We add EXTRA_CFLAGS to the common CFLAGS of top-level Makefile > which will allow users to pass additional compile-time flags such > as "-static". > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > tools/testing/selftests/kvm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile > index c4e34717826a..ee6740e9ecdb 100644 > --- a/tools/testing/selftests/kvm/Makefile > +++ b/tools/testing/selftests/kvm/Makefile > @@ -131,7 +131,7 @@ endif > CFLAGS += -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99 \ > -fno-stack-protector -fno-PIE -I$(LINUX_TOOL_INCLUDE) \ > -I$(LINUX_TOOL_ARCH_INCLUDE) -I$(LINUX_HDR_PATH) -Iinclude \ > - -I$(<D) -Iinclude/$(UNAME_M) -I.. > + -I$(<D) -Iinclude/$(UNAME_M) -I.. $(EXTRA_CFLAGS) > > no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \ > $(CC) -Werror -no-pie -x c - -o "$$TMP", -no-pie) > -- > 2.25.1 > Reviewed-by: Atish Patra <atishp@rivosinc.com> -- Regards, Atish
On Mon, Nov 29, 2021, Anup Patel wrote: > We add EXTRA_CFLAGS to the common CFLAGS of top-level Makefile Nit, wrap closer to 75 chars. > which will allow users to pass additional compile-time flags such > as "-static". In case there's any hesitation in applying this (Paolo asked if this was just for debugging in v1), being able to pass "-static" is helpful for our environment as our test systems have a funky and minimal configuration (no gcc, and the interpreter is in a weird location). Running selftests either requires building them with -static or creating a symbolic link for /lib64/ld-linux-x86-64.so.2. It's generally easier to just tell people to compile with -static. > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- Reviewed-and-tested-by: Sean Christopherson <seanjc@google.com>
On Tue, Dec 21, 2021 at 1:15 AM Sean Christopherson <seanjc@google.com> wrote: > > On Mon, Nov 29, 2021, Anup Patel wrote: > > We add EXTRA_CFLAGS to the common CFLAGS of top-level Makefile > > Nit, wrap closer to 75 chars. Okay, I will update. > > > which will allow users to pass additional compile-time flags such > > as "-static". > > In case there's any hesitation in applying this (Paolo asked if this was just for > debugging in v1), being able to pass "-static" is helpful for our environment as > our test systems have a funky and minimal configuration (no gcc, and the interpreter > is in a weird location). Running selftests either requires building them with > -static or creating a symbolic link for /lib64/ld-linux-x86-64.so.2. It's generally > easier to just tell people to compile with -static. > > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > > --- > > Reviewed-and-tested-by: Sean Christopherson <seanjc@google.com> Thanks, I am planning to queue this for 5.17. Currently, I am waiting for some reviews on the PATCH4 (last patch). Regards, Anup
diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile index c4e34717826a..ee6740e9ecdb 100644 --- a/tools/testing/selftests/kvm/Makefile +++ b/tools/testing/selftests/kvm/Makefile @@ -131,7 +131,7 @@ endif CFLAGS += -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99 \ -fno-stack-protector -fno-PIE -I$(LINUX_TOOL_INCLUDE) \ -I$(LINUX_TOOL_ARCH_INCLUDE) -I$(LINUX_HDR_PATH) -Iinclude \ - -I$(<D) -Iinclude/$(UNAME_M) -I.. + -I$(<D) -Iinclude/$(UNAME_M) -I.. $(EXTRA_CFLAGS) no-pie-option := $(call try-run, echo 'int main() { return 0; }' | \ $(CC) -Werror -no-pie -x c - -o "$$TMP", -no-pie)
We add EXTRA_CFLAGS to the common CFLAGS of top-level Makefile which will allow users to pass additional compile-time flags such as "-static". Signed-off-by: Anup Patel <anup.patel@wdc.com> --- tools/testing/selftests/kvm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)