| Message ID | 20211203023213.5021-1-zhijianx.li@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0f8a3b48f91b8dc1f3eff06b77a63a17183fccbd |
| Headers | show |
| Series | selftests: net/fcnal-test.sh: add exit code | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Fri, 3 Dec 2021 10:32:13 +0800 you wrote: > Previously, the selftest framework always treats it as *ok* even though > some of them are failed actually. That's because the script always > returns 0. > > It supports PASS/FAIL/SKIP exit code now. > > CC: Philip Li <philip.li@intel.com> > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Li Zhijian <zhijianx.li@intel.com> > > [...] Here is the summary with links: - selftests: net/fcnal-test.sh: add exit code https://git.kernel.org/netdev/net/c/0f8a3b48f91b You are awesome, thank you!
diff --git a/tools/testing/selftests/net/fcnal-test.sh b/tools/testing/selftests/net/fcnal-test.sh index 3313566ce906..46297ceaa6d1 100755 --- a/tools/testing/selftests/net/fcnal-test.sh +++ b/tools/testing/selftests/net/fcnal-test.sh @@ -4077,3 +4077,11 @@ cleanup 2>/dev/null printf "\nTests passed: %3d\n" ${nsuccess} printf "Tests failed: %3d\n" ${nfail} + +if [ $nfail -ne 0 ]; then + exit 1 # KSFT_FAIL +elif [ $nsuccess -eq 0 ]; then + exit $ksft_skip +fi + +exit 0 # KSFT_PASS
Previously, the selftest framework always treats it as *ok* even though some of them are failed actually. That's because the script always returns 0. It supports PASS/FAIL/SKIP exit code now. CC: Philip Li <philip.li@intel.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Li Zhijian <zhijianx.li@intel.com> --- tools/testing/selftests/net/fcnal-test.sh | 8 ++++++++ 1 file changed, 8 insertions(+)