Message ID | 20220207211144.1948690-5-ribalda@chromium.org (mailing list archive) |
---|---|
State | Accepted |
Commit | 741c9286ffad332fd0ff1cae01d497ec4b0176e5 |
Headers | show |
Series | [v3,1/6] kunit: Introduce _NULL and _NOT_NULL macros | expand |
On Mon, Feb 7, 2022 at 1:11 PM Ricardo Ribalda <ribalda@chromium.org> wrote: > > Replace the PTR_EQ NULL checks wit the NULL macros. More idiomatic and > specific. > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> Acked-by: Daniel Latypov <dlatypov@google.com> > --- > net/mctp/test/route-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/mctp/test/route-test.c b/net/mctp/test/route-test.c > index 750f9f9b4daf..eb70b524c78e 100644 > --- a/net/mctp/test/route-test.c > +++ b/net/mctp/test/route-test.c > @@ -361,7 +361,7 @@ static void mctp_test_route_input_sk(struct kunit *test) > } else { > KUNIT_EXPECT_NE(test, rc, 0); > skb2 = skb_recv_datagram(sock->sk, 0, 1, &rc); > - KUNIT_EXPECT_PTR_EQ(test, skb2, NULL); > + KUNIT_EXPECT_NULL(test, skb2); > } > > __mctp_route_test_fini(test, dev, rt, sock); > @@ -430,7 +430,7 @@ static void mctp_test_route_input_sk_reasm(struct kunit *test) > skb_free_datagram(sock->sk, skb2); > > } else { > - KUNIT_EXPECT_PTR_EQ(test, skb2, NULL); > + KUNIT_EXPECT_NULL(test, skb2); > } > > __mctp_route_test_fini(test, dev, rt, sock); > -- > 2.35.0.263.gb82422642f-goog >
diff --git a/net/mctp/test/route-test.c b/net/mctp/test/route-test.c index 750f9f9b4daf..eb70b524c78e 100644 --- a/net/mctp/test/route-test.c +++ b/net/mctp/test/route-test.c @@ -361,7 +361,7 @@ static void mctp_test_route_input_sk(struct kunit *test) } else { KUNIT_EXPECT_NE(test, rc, 0); skb2 = skb_recv_datagram(sock->sk, 0, 1, &rc); - KUNIT_EXPECT_PTR_EQ(test, skb2, NULL); + KUNIT_EXPECT_NULL(test, skb2); } __mctp_route_test_fini(test, dev, rt, sock); @@ -430,7 +430,7 @@ static void mctp_test_route_input_sk_reasm(struct kunit *test) skb_free_datagram(sock->sk, skb2); } else { - KUNIT_EXPECT_PTR_EQ(test, skb2, NULL); + KUNIT_EXPECT_NULL(test, skb2); } __mctp_route_test_fini(test, dev, rt, sock);
Replace the PTR_EQ NULL checks wit the NULL macros. More idiomatic and specific. Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- net/mctp/test/route-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)