| Message ID | 20220318075013.48964-1-guozhengkui@vivo.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [linux-next,v2] selftests: net: change fprintf format specifiers | expand |
On Fri, 18 Mar 2022 15:50:13 +0800 Guo Zhengkui wrote: > `cur64`, `start64` and `ts_delta` are int64_t. Change > format specifiers in fprintf from '%lu' to '%ld'. > > It has been tested with gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 > on x86_64. No, not like that. Please read up on printing int64_t.
On 2022/3/19 0:33, Jakub Kicinski wrote: > On Fri, 18 Mar 2022 15:50:13 +0800 Guo Zhengkui wrote: >> `cur64`, `start64` and `ts_delta` are int64_t. Change >> format specifiers in fprintf from '%lu' to '%ld'. >> >> It has been tested with gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 >> on x86_64. > > No, not like that. Please read up on printing int64_t. Sorry for misunderstanding. I wrongly thought that it's just for 64-bit. So I should use `PRId64`. Zhengkui
diff --git a/tools/testing/selftests/net/txtimestamp.c b/tools/testing/selftests/net/txtimestamp.c index fabb1d555ee5..b8a52995a635 100644 --- a/tools/testing/selftests/net/txtimestamp.c +++ b/tools/testing/selftests/net/txtimestamp.c @@ -161,7 +161,7 @@ static void validate_timestamp(struct timespec *cur, int min_delay) max_delay = min_delay + cfg_delay_tolerance_usec; if (cur64 < start64 + min_delay || cur64 > start64 + max_delay) { - fprintf(stderr, "ERROR: %lu us expected between %d and %d\n", + fprintf(stderr, "ERROR: %ld us expected between %d and %d\n", cur64 - start64, min_delay, max_delay); test_failed = true; } @@ -170,9 +170,9 @@ static void validate_timestamp(struct timespec *cur, int min_delay) static void __print_ts_delta_formatted(int64_t ts_delta) { if (cfg_print_nsec) - fprintf(stderr, "%lu ns", ts_delta); + fprintf(stderr, "%ld ns", ts_delta); else - fprintf(stderr, "%lu us", ts_delta / NSEC_PER_USEC); + fprintf(stderr, "%ld us", ts_delta / NSEC_PER_USEC); } static void __print_timestamp(const char *name, struct timespec *cur,
`cur64`, `start64` and `ts_delta` are int64_t. Change format specifiers in fprintf from '%lu' to '%ld'. It has been tested with gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0 on x86_64. Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com> --- tools/testing/selftests/net/txtimestamp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)