| Message ID | 20220516165856.401452-1-antonio.terceiro@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | kselftest: alsa: handle cross compilation | expand |
On Mon, May 16, 2022 at 01:58:56PM -0300, Antonio Terceiro wrote: > Calling just `pkg-config` is adequate for native builds, but finding the > foreign libraries with pkg-config needs pkg-config to be called via its > architecture-specific wrapper. This works in Debian, where there is a > corresponding *-pkg-config wrapper script for each enabled foreign > architecture, just like there are *-gcc, *-ld. Why does this only apply to the ALSA selftests? There's a bunch of kselftests that use unadorned pkg-config calls.
diff --git a/tools/testing/selftests/alsa/Makefile b/tools/testing/selftests/alsa/Makefile index f64d9090426d..f5675b3c929d 100644 --- a/tools/testing/selftests/alsa/Makefile +++ b/tools/testing/selftests/alsa/Makefile @@ -1,8 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 # -CFLAGS += $(shell pkg-config --cflags alsa) -LDLIBS += $(shell pkg-config --libs alsa) +PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config + +CFLAGS += $(shell $(PKG_CONFIG) --cflags alsa) +LDLIBS += $(shell $(PKG_CONFIG) --libs alsa) TEST_GEN_PROGS := mixer-test
Calling just `pkg-config` is adequate for native builds, but finding the foreign libraries with pkg-config needs pkg-config to be called via its architecture-specific wrapper. This works in Debian, where there is a corresponding *-pkg-config wrapper script for each enabled foreign architecture, just like there are *-gcc, *-ld. Signed-off-by: Antonio Terceiro <antonio.terceiro@linaro.org> --- tools/testing/selftests/alsa/Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)